Skip to content

Respect STOP_DETAIL_CONCEAL_LIVENESS_STRING feature flag#314

Merged
emilymclean merged 1 commit intodevelopfrom
mclean/fix/respect-conceal-liveness-flag
Feb 21, 2026
Merged

Respect STOP_DETAIL_CONCEAL_LIVENESS_STRING feature flag#314
emilymclean merged 1 commit intodevelopfrom
mclean/fix/respect-conceal-liveness-flag

Conversation

@emilymclean
Copy link
Copy Markdown
Owner

@emilymclean emilymclean commented Feb 21, 2026

Summary by Sourcery

New Features:

  • Allow stop time text to bypass liveness status strings when the STOP_DETAIL_CONCEAL_LIVENESS_STRING feature flag is active.

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai bot commented Feb 21, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adds conditional behavior to the StopStationTime.text computed property so that when the STOP_DETAIL_CONCEAL_LIVENESS_STRING feature flag is enabled, the raw time string is returned without liveness/lateness messaging.

Flow diagram for StopStationTime_text feature flag behavior

flowchart TD
    A[Start computing StopStationTime_text] --> B[Compute timeString]
    B --> C{FeatureFlag.STOP_DETAIL_CONCEAL_LIVENESS_STRING.value}
    C -->|true| D[Return timeString]
    C -->|false| E{late?}
    E -->|true| F[Return scheduled_delay_late stringResource with timeString]
    E -->|false| G[Return other liveness/lateness stringResource]
Loading

File-Level Changes

Change Details Files
Gate liveness/late messaging behind STOP_DETAIL_CONCEAL_LIVENESS_STRING feature flag in StopCard UI.
  • Update StopStationTime.text getter to first check the STOP_DETAIL_CONCEAL_LIVENESS_STRING feature flag.
  • Return the plain timeString when the feature flag is enabled, bypassing late/on-time message formatting.
  • Preserve the existing late/on-time stringResource-based behavior when the feature flag is disabled.
ui/src/commonMain/kotlin/cl/emilym/sinatra/ui/widgets/StopCard.kt

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions github-actions bot added the fix label Feb 21, 2026
Copy link
Copy Markdown

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@emilymclean emilymclean merged commit b475596 into develop Feb 21, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant