Nova flexible content compatibility and error message styling fix #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update master from Daan's fork
… when the Nova event 'flexible-content-order-changed' is emitted
…tability Update NPM and composer packages & allow the editor to be re-rendered on the 'flexible-content-order-changed' event in Nova
… when the Nova event 'flexible-content-order-changed' is emitted
# Conflicts: # composer.json # dist/js/field.js # dist/js/tinymce.js # dist/tinymce/skins/ui/oxide-dark/content.css # dist/tinymce/skins/ui/oxide-dark/content.inline.css # dist/tinymce/skins/ui/oxide-dark/content.inline.min.css # dist/tinymce/skins/ui/oxide-dark/content.min.css # dist/tinymce/skins/ui/oxide-dark/skin.css # dist/tinymce/skins/ui/oxide-dark/skin.min.css # dist/tinymce/skins/ui/oxide/content.css # dist/tinymce/skins/ui/oxide/content.inline.css # dist/tinymce/skins/ui/oxide/content.inline.min.css # dist/tinymce/skins/ui/oxide/content.min.css # dist/tinymce/skins/ui/oxide/skin.css # dist/tinymce/skins/ui/oxide/skin.min.css # dist/tinymce/skins/ui/tinymce-5-dark/content.css # dist/tinymce/skins/ui/tinymce-5-dark/content.inline.css # dist/tinymce/skins/ui/tinymce-5-dark/content.inline.min.css # dist/tinymce/skins/ui/tinymce-5-dark/content.min.css # dist/tinymce/skins/ui/tinymce-5-dark/skin.css # dist/tinymce/skins/ui/tinymce-5-dark/skin.min.css # dist/tinymce/skins/ui/tinymce-5/content.css # dist/tinymce/skins/ui/tinymce-5/content.inline.css # dist/tinymce/skins/ui/tinymce-5/content.inline.min.css # dist/tinymce/skins/ui/tinymce-5/content.min.css # dist/tinymce/skins/ui/tinymce-5/skin.css # dist/tinymce/skins/ui/tinymce-5/skin.min.css # package.json # resources/js/components/FormField.vue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the same as #84 but it also updates TinyMCE and changes the classes used on the error message shown below the field whenever the validation fails. Nova now uses the classes
help-text help-text-errorfor this.I've understood that you're not maintaining this repository anymore, but hopefully by merging this PR you may help some others who'd like to use this field together with the Nova Flexible Content package, as long as the Flexible Content Package also emits the right event. We currently do this here: https://github.com/scholieren-com/nova-flexible-content/blob/master/resources/js/components/FormGroup.vue#L196, but I'm hoping to get that merged as well.