tests: fix failures when run as root user #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wiselike
force-pushed
the
fix-tests-in-root
branch
from
1886a06 to
4e4a372
Compare
emikulic
reviewed
Jun 2, 2025
devel/run-tests
Outdated
| PID=$! | ||
| if [[ $(id -u) -eq 0 ]]; then | ||
| touch test.out.log darkhttpd.gcda && chmod 0777 test.out.log darkhttpd.gcda; | ||
| sudo -u nobody ./a.out $DIR --port $PORT --addr $ADDR --log test.out.log >>test.out.stdout 2>>test.out.stderr & |
Owner
There was a problem hiding this comment.
Can we "sudo -u nobody run-tests" instead? I don't like the duplication here.
wiselike
force-pushed
the
fix-tests-in-root
branch
from
4e4a372 to
bbbabee
Compare
emikulic
reviewed
Jun 3, 2025
devel/Makefile
Outdated
| all: | ||
| ./run-tests | ||
| @chmod a+w "$(THIS_DIR)/../devel" | ||
| sudo -u nobody ./run-tests |
Owner
There was a problem hiding this comment.
I meant do this in the Dockerfile. :)
Or "sudo make all" if you really want to go via the Makefile.
Author
|
There are several methods to run the tests:
We cannot strictly dictate which method users must use. Additionally, we should avoid implying that "running tests as root is not supported" (users should have flexibility in their environment configuration). I believe we should be able to run |
wiselike
force-pushed
the
fix-tests-in-root
branch
from
bbbabee to
9d54e36
Compare
Signed-off-by: hengwu0 <17380582683@163.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix bug #76