Skip to content

Fix for missing cmd.py in default config that leads to a segfault #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
and3rson wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix for missing cmd.py in default config that leads to a segfault #91

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
09f4e65
Fix for missing cmd.py in default config that leads to a segfault
and3rson Dec 12, 2016
acd1d91
Cleanup.
and3rson Dec 12, 2016
4bc0c6d
More cleanup.
and3rson Dec 12, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/lighthouse.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -705,7 +705,12 @@ int main(int argc, char **argv) {
/* Set up the remote process. */
int32_t to_child_fd, from_child_fd;

char *exec_file = settings.cmd;
char *exec_file;
if(access(settings.cmd, F_OK) == -1) {
exec_file = "/usr/share/lighthouse/cmd.py";
Copy link
Owner

@emgram769 emgram769 Jul 29, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this isn't particularly informative/portable. perhaps mimic lines 716-718? something like this:

fprintf(stderr, "No 'cmd' set, please edit your lighthouserc or run lighthouse-install");
exit_code = 1;
return exit_code;

} else {
exec_file = settings.cmd;
}

if (spawn_piped_process(exec_file, &to_child_fd, &from_child_fd, (char **)cmdargs)) {
fprintf(stderr, "Failed to spawn piped process.\n");
Expand Down