Skip to content

Conversation

@yanjustino
Copy link
Contributor

This pull request introduces enhancements to the GherXunit framework, focusing on improving usability through global configuration for lexers, updating documentation, and versioning. The most important changes include the addition of a global default lexer configuration, updates to the documentation in README.md, and the release of version 1.3.0.

Framework Enhancements:

  • Introduced the GherXunitConfig.DefaultLexer property to allow setting a global default lexer for all tests, simplifying configuration and reducing redundancy. (src/base/GherXunit.Core/StringHandler.cs, src/lib/GherXunit/GherXunit.Content.StringHandler.cs) [1] [2]
  • Updated methods to use the global default lexer (GherXunitConfig.DefaultLexer) if specified, falling back to the default lexers otherwise. (src/base/GherXunit.Core/Methods.cs, src/lib/GherXunit/GherXunit.Content.Methods.cs) [1] [2]

Documentation Updates:

  • Revised README.md to include new sections on the benefits of GherXunit, usage examples, references, and instructions for defining the global lexer. Removed outdated content about custom lexers. [1] [2]

Versioning:

  • Bumped the version of GherXunit from 1.2.0 to 1.3.0 to reflect the new features and improvements. (src/lib/GherXunit/GherXunit.csproj)

Funding Information:

  • Added a FUNDING.yml file to specify supported funding platforms and sponsorship options for project contributors. (.github/FUNDING.yml)

@yanjustino yanjustino requested a review from Copilot June 20, 2025 17:48
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a global default lexer setting to simplify test configuration, updates documentation to reflect the new feature, bumps the package version to 1.3.0, and includes funding metadata.

  • Introduces GherXunitConfig.DefaultLexer and updates handler methods to honor it.
  • Updates README.md with new usage guidance and removes outdated custom-lexer section.
  • Bumps version to 1.3.0 and adds .github/FUNDING.yml.

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/lib/GherXunit/GherXunit.csproj Version bumped from 1.2.0 to 1.3.0
src/lib/GherXunit/GherXunit.Content.StringHandler.cs Adds GherXunitConfig for global default lexer
src/lib/GherXunit/GherXunit.Content.Methods.cs Uses GherXunitConfig.DefaultLexer as fallback
src/base/GherXunit.Core/StringHandler.cs Adds duplicate GherXunitConfig in core assembly
src/base/GherXunit.Core/Methods.cs Updates core methods to use global default lexer
src/base/GherXunit.Core/Samples/LocalizationTest.cs Sample now sets GherXunitConfig.DefaultLexer
README.md Replaces custom-lexer docs with global-lexer guide
.github/FUNDING.yml Adds project funding configuration
Comments suppressed due to low confidence (1)

src/lib/GherXunit/GherXunit.Content.Methods.cs:77

  • There should be a unit test verifying that GherXunitConfig.DefaultLexer is applied when lexer is null, ensuring the fallback logic is covered.
                var stepString = new StringHandler(lexer ?? GherXunitConfig.DefaultLexer ?? Lexers.Default);

@yanjustino yanjustino self-assigned this Jun 20, 2025
@yanjustino yanjustino merged commit 1f5b43c into main Jun 20, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants