Clear review text when switching between addons #224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgengler
force-pushed
the
fix-review-note-not-clearing
branch
from
afac92b to
8887450
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when reviewing multiple addons, the review text isn't cleared when switching. This fixes that.
It also converts the
<AdminAddon/>and<AdminAddonReviewForm/>components to be Glimmer components instead of classic components; to do this I upgradedember-concurrencyto the latest (currently^2.1.2) and added thetracked-built-inspackage. The latter means that we would have to drop IE11 support; if we want to keep it I can refactor to use anEmberObjectin place of theTrackedObject.