Support receivedSprites in moveOver#233
Open
dwilhelmi wants to merge 1 commit intoember-animation:masterfrom
Open
Support receivedSprites in moveOver#233dwilhelmi wants to merge 1 commit intoember-animation:masterfrom
dwilhelmi wants to merge 1 commit intoember-animation:masterfrom
Conversation
Benkooo
approved these changes
Sep 1, 2022
Collaborator
|
@dwilhelmi mind to rebase as addon structure has changed since then? If this looks good from @ef4 side, I can re-create the PR with proper file location unless @dwilhelmi can do the same. |
Contributor
|
I haven't deeply thought about whether this is the right animation but since this new code will only run in a case that would have completely failed before I'm fine with it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes at least one case where you can get the Unimplemented error from the moveOver transition. Specifically, we saw this happen when performing a moveOver transition while doing a route transition. Adding support for receivedSprites fixed our issue locally.
This should help address #208