Skip to content

Support negative values in box-shadow string parsing#181

Open
emattias wants to merge 1 commit intoember-animation:masterfrom
emattias:support-negative-box-shadow-values
Open

Support negative values in box-shadow string parsing#181
emattias wants to merge 1 commit intoember-animation:masterfrom
emattias:support-negative-box-shadow-values

Conversation

@emattias
Copy link

@emattias emattias commented Dec 5, 2019

Without this you get unable to parse color error when animating box-shadow that has negative values. For example:

      boxShadow(sprite, {
        from:
          'rgba(0, 0, 0, 0.1) 0px 18px 12px -12px, rgba(0, 0, 0, 0.1) 0px 5px 23px 10px',
      });

@emattias emattias force-pushed the support-negative-box-shadow-values branch from ba2f941 to 5c9ab46 Compare December 5, 2019 13:49
@ef4
Copy link
Contributor

ef4 commented Dec 6, 2019

Thanks.

There is already pretty good test infrastructure for this here if you wouldn't mind adding some examples to cover this.

While we're at it, I suppose the spec probably allows decimals too. We'd better check what the precise grammar is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants