Open
Conversation
The demo-3 component only works when used on the index route. I noticed because I started trying to write an integration test for it, and it couldn't render its images correctly there.
Contributor
|
I took some time to look through these commits, to try to understand both how to test animations and what this particular fix entailed. First – I'm blown away by how you're able to test such a complex animation. Truly! This is an amazing aspect of this lib that deserves an entire section and multiple guides in the docs. Second, for this particular bug, I'd like to check my understanding. Let's just focus on
Amazing PR and thank you so much for taking the time to fix & write such clear code! |
Contributor
Author
|
I sat down to try to answer this question and realized I don't actually have the fully detailed answer. I need to run the code again to see it in more detail. 🤪 |
Contributor
|
@ef4 ping |
Contributor
|
I can fix the conflicts but still curious on the explanation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #105.
This is deliberately grouped into multiple commits with different purposes to ease review.