Skip to content

Fix agenda properties#598

Merged
ricardoricho merged 2 commits intoemacs-dashboard:masterfrom
ricardoricho:fix-agenda-properties
Mar 29, 2026
Merged

Fix agenda properties#598
ricardoricho merged 2 commits intoemacs-dashboard:masterfrom
ricardoricho:fix-agenda-properties

Conversation

@ricardoricho
Copy link
Copy Markdown
Member

Due to the indentation in we introduce a bug where icons and properties were missing from agenda items.
This fix the issue and add checkout to the ci workflow. I want to add easklint packages, but it fails because recentf-list variable, so it's time to refactor the recents section before adding the linter to the workflow.

Copy link
Copy Markdown
Member

@jcs090218 jcs090218 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good! :D

dashboard.el Outdated
;; Package-Version: 1.9.0-SNAPSHOT
;; Keywords: startup, screen, tools, dashboard
;; Package-Requires: ((emacs "27.1"))
;; Package-Requires: ((emacs "27.2"))
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm.. why are we dropping Emacs 27.1? 🤔

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we are going to drop it in the near future. I t solves some issues with eask lint package . Emacs 27.2 is 5 years old and I see it as the last stable release from 27.
Also, we are running the tests with 27.2
I reverted the change because the lint package is failing and the errors will be fixed in another PR.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That make sense. I think we can drop 27 entirely. :)

@jcs090218
Copy link
Copy Markdown
Member

This fix the issue and add checkout to the ci workflow. I want to add easklint packages, but it fails because recentf-list variable, so it's time to refactor the recents section before adding the linter to the workflow.

It was on my to-do list forever. I didn't bother to add them since dashboard was stable enough for me. 😅 But it's always nice to have those linters check! 😉

@jcs090218 jcs090218 added the bug label Mar 27, 2026
@ricardoricho ricardoricho force-pushed the fix-agenda-properties branch from 04768fd to f9496d6 Compare March 27, 2026 16:57
@ricardoricho ricardoricho merged commit 56470b6 into emacs-dashboard:master Mar 29, 2026
24 of 28 checks passed
@ricardoricho ricardoricho deleted the fix-agenda-properties branch March 29, 2026 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants