Add PHP 8.3 and 8.4 support #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for PHP 8.3 and 8.4 in the CI pipeline while preserving backward compatibility, updates method signatures in LitEmoji to use nullable types, and bumps the GitHub Actions cache action to v4.
- Updated encoding methods to accept
?string $encodinginstead ofstring $encoding = null - Expanded the GitHub Actions PHP matrix to include versions 8.3 and 8.4
- Upgraded
actions/cachefromv2tov4intests.yml
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/LitEmoji.php | Changed four methods to use nullable ?string $encoding type hints |
| .github/workflows/tests.yml | Added PHP 8.3 & 8.4 to matrix; bumped actions/cache to v4 |
Comments suppressed due to low confidence (1)
.github/workflows/tests.yml:33
- Consider adding a
restore-keyssetting (e.g.,restore-keys: ${{ runner.os }}-composer-) to the cache step to improve cache hit rates when the lockfile changes.
uses: actions/cache@v4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for PHP 8.3 and 8.4 whilst maintaining backwards compatibility.
It also upgrades
actions/cachein the GitHub Actions file tov4.