[bugfix] Ensure configuration is re-applied periodically even without config file #427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fako1024
added
bug
fako1024
commented
Dec 22, 2025
| "removed", disableIfaces, | ||
| ), | ||
| ).Info("updated interface configuration") | ||
| if len(enableIfaces) > 0 || len(updateIfaces) > 0 || len(disableIfaces) > 0 { |
Collaborator
Author
There was a problem hiding this comment.
Drive-by: Reduce info-level log lines in case there is no change (no need to spam logs with null-op info unless debug logging is enabled).
fako1024
commented
Dec 22, 2025
| // Note: exact counts are timing-sensitive and can be flaky across environments, | ||
| // so we only verify presence rather than a specific minimum beyond 1. | ||
| keepaliveCount := 0 | ||
| sender.mu.Lock() |
Collaborator
Author
There was a problem hiding this comment.
Drive-by: Racy, racy, such a sorrow. I smell AI... 😉
els0r
approved these changes
Dec 22, 2025
fako1024
deleted the
426-config-interface-reload-not-triggered-unless-config-file-is-present
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #426