Open
Conversation
Owner
|
I think you are right! Thank you for the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I could be wrong about these, but:
%operator was applied to thedxcomponent (that should basically never happen, afaict)dxto 0 in a few cases (floor,ceil,round, etc). These functions are flat everywhere they're differentiable, epsilon perturbations will always leave the value unchanged, so thedxcomponent should be wiped out by them, unless I'm mistaken.I considered adding tests but simple tests would just repeat my assumptions about how the math should work (e.g. asserting
dx == 0in some cases). It would be nice to add tests that perturb values byEPSILON, and verify that the empirical and theoretical gradients match. I'm open to trying that out, but maybe as a follow-on PR, as ≈all of the operations warrant that, not just the ones I've touched here.