Skip to content

Fix slice index out of range #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yi-xmu merged 2 commits into from
Jan 5, 2026
Merged

Fix slice index out of range #333

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
69341d3
Fix slice index out of range
yi-xmu Jan 4, 2026
4d23ba4
update
yi-xmu Jan 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions tx_service/include/cc/cc_request.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4342,6 +4342,8 @@ struct RangePartitionDataSyncScanCc : public CcRequestBase

bool IsSlicePinned(uint16_t core_id) const
{
assert(export_base_table_item_ ||
curr_slice_index_[core_id] < slices_to_scan_.size());
return export_base_table_item_
? true
: slices_to_scan_[curr_slice_index_[core_id]].second;
Expand Down
12 changes: 10 additions & 2 deletions tx_service/include/cc/template_cc_map.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5610,7 +5610,11 @@ class TemplateCcMap : public CcMap
recycle_ts = shard_->GlobalMinSiTxStartTs();
}

bool slice_pinned = req.IsSlicePinned(shard_->core_id_);
// If reach to the batch end, it means there are no slices that need to
// be scanned.
bool slice_pinned = req.TheBatchEnd(shard_->core_id_)
? false
: req.IsSlicePinned(shard_->core_id_);
// The following flag is used to mark the behavior of one slice.
// Only need to export the key if the key is already persisted, this
// will happen when the slice need to split, and should export all the
Expand Down Expand Up @@ -5718,7 +5722,11 @@ class TemplateCcMap : public CcMap
std::tie(key_it, slice_end_it, slice_end_key) =
find_non_empty_slice(*search_start_key);

slice_pinned = req.IsSlicePinned(shard_->core_id_);
// If reach to the batch end, it means there are no slices
// that need to be scanned.
slice_pinned = req.TheBatchEnd(shard_->core_id_)
? false
: req.IsSlicePinned(shard_->core_id_);
export_persisted_key_only =
!req.export_base_table_item_ && slice_pinned;
}
Expand Down