Skip to content

Fix cluster restart failure after bootstrap with built-in log service #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Fix cluster restart failure after bootstrap with built-in log service #266

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
346d85a
Initial plan
Copilot Dec 5, 2025
12df95c
Add proactive log group leader refresh on initialization
Copilot Dec 5, 2025
8d9f1df
Add logging for log group leader refresh operations
Copilot Dec 5, 2025
7ebe25b
Add validation and documentation for log group leader refresh
Copilot Dec 5, 2025
ba9e23e
Polish code formatting and style
Copilot Dec 5, 2025
5adce30
Remove codeql temporary file and add to gitignore
Copilot Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,3 +358,4 @@ compile_commands.json

cmake-build-debug/
.cache
_codeql_detected_source_root
23 changes: 23 additions & 0 deletions tx_service/src/sharder.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,6 +213,29 @@ int Sharder::Init(
if (log_agent_ != nullptr)
{
log_agent_->Init(txlog_ips_, txlog_ports_, 0);
// Refresh leader information for all log groups immediately after
// initialization to ensure we have current leader info, especially
// important after cluster restart when leaders may have changed.
uint32_t log_group_count = log_agent_->LogGroupCount();
if (log_group_count == 0)
{
LOG(WARNING)
<< "No log groups found after log agent initialization. "
"Log service may not be properly configured.";
}
else
{
LOG(INFO) << "Refreshing leader info for " << log_group_count
<< " log group(s) after initialization";
for (uint32_t lg_id = 0; lg_id < log_group_count; ++lg_id)
{
// RefreshLeader is typically a lightweight operation that
// updates internal cache. The log service will handle any
// connection issues gracefully with retries.
log_agent_->RefreshLeader(lg_id);
DLOG(INFO) << "Refreshed leader for log group " << lg_id;
}
}
}

#ifdef EXT_TX_PROC_ENABLED
Expand Down