-
Notifications
You must be signed in to change notification settings - Fork 24
Branch support #412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
githubzilla
wants to merge
64
commits into
main
Choose a base branch
from
branch_support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+6,196
−1,156
Open
Branch support #412
Changes from all commits
Commits
Show all changes
64 commits
Select commit
Hold shift + click to select a range
4dbc6ba
feat: implement branch design feature
githubzilla 9d75b65
Fix regressions from manual merge: restore branch_design API usage
githubzilla 9128ae4
Fix CURRENT_TERM cloud upload to use per-branch suffix
githubzilla 6f6c349
fix: re-enqueue CreateBranch/DeleteBranch when task pool is exhausted
githubzilla 0388a6f
fix: treat empty/stub partition as success in CreateBranch
githubzilla a318f92
fix: treat AlreadyExists as success in HandleGlobalCreateBranchReques…
githubzilla 5a06928
fix: fallback to active branch in OnDataFileSealed when file_id mappi…
githubzilla 844270c
CreateBranch should fail if branch already exist
githubzilla 8491b8c
Fix build error
githubzilla a98d05d
Fix clang-format
githubzilla 41265a9
Fix clang-format
githubzilla 85bc8e7
fix: port 204ff65 and 3a6f964 to branch_support
githubzilla a4fbc71
refactor: move branch_name before term in DownloadFile signature
githubzilla 3e0fd12
Fix manifest deletion bug in file_gc
githubzilla 791301e
fix: set branch_name and term on manifest FD and normalize directory …
githubzilla 871ad9a
Remove redundant GetFileIdTerm call in InstallExternalSnapshot
githubzilla c95834b
Remove GetFileIdTerm and use ProcessTerm() directly in write paths
githubzilla 710795a
Intern branch name strings in LruFD to avoid per-FD heap allocations
githubzilla 8716246
Add debug log
githubzilla 32defc9
Remove DataFileName function, using BranchDataFileName instead
githubzilla 59edca4
Refine logs
githubzilla c57ddd6
Fix ReadFilePrefix race: read from cached FD instead of opening by path
githubzilla 07497ba
Add debug log
githubzilla 48deb9f
Fix OpenOrCreateFD reusing cached FD with stale branch_name
githubzilla 439874c
debug log
githubzilla de93348
Use active branch when max_file_id not found when install external sn…
githubzilla eacca8b
Branch name should not be null when compare cached fd and file to open
githubzilla 710e964
Remove not used funtion of FilePageAllocatore::SetCurrentFileId
githubzilla f5b5881
Pass term as parameter to CreateArchive instead of calling ProcessTer…
githubzilla 90e9d27
Remove default parameter values from OpenFD and OpenOrCreateFD
githubzilla cb84620
Remove default values and reorder branch_name parameter in CloudStore…
githubzilla 43523b9
Use system_clock instead of high_resolution_clock for branch name salt
githubzilla 017fc27
Remove BranchBaseNameExists duplicate-name check and dead code
githubzilla d3272c1
Remove duplicate branch name test cases
githubzilla e64418b
Remove unused BranchManifestExists and BranchCurrentTermExists
githubzilla 240acbe
Refactor ParseBranchTerm to return bool and propagate parse errors
githubzilla 1216ba5
Remove unused parent_branch_ from GlobalCreateBranchRequest
githubzilla 7e32e07
Add back comments for GetMetricsMeter
githubzilla 6e6cbdd
Add AlreadyExists to FFI error enums and converters
githubzilla d2d85e7
Call SetBranchFileMapping unconditionally to clear stale mappings
githubzilla f3b9bdb
Fix some review comment
githubzilla 9009c6d
Roll back orphaned manifest when WriteBranchCurrentTerm fails in Crea…
githubzilla 9efb2ec
Add debug log
githubzilla 3e512a9
Add debug log
githubzilla 08dbc15
Remove unused file_id_term_mapping_dirty_ variable from WriteTask
githubzilla 9ab46ae
Rename term_buf
githubzilla 5a3bc79
Remove unused FileIdTermMapping type and related dead code
githubzilla 992e36c
Fix missing store_path_lut argument in DeleteOldArchives
githubzilla c63bb30
Register manifest_payload test in CMakeLists.txt
githubzilla 142d1f4
Value-initialize BranchFileRange and BranchManifestMetadata members
githubzilla 769ef8e
Add BranchManifestMetadata serialization tests
githubzilla cd86ccb
Assert Start() return value in cloud tests
githubzilla cca963d
Assert Start() return value in persist and manifest tests
githubzilla d822a69
Filter all CURRENT_TERM files in CheckCloudPartitionExists
githubzilla 20c5512
Change DeserializeBranchManifestMetadata to return bool with out para…
githubzilla f7c6fd3
Check Start() return value in benchmarks and concurrent_test
githubzilla ffe3c84
Propagate errors from AugmentRetainedFilesFromBranchManifests instead…
githubzilla 2497fdf
Use GetActiveBranch() for manifest selection in cloud GC
githubzilla ecd451e
Update comment for removing current branch term
githubzilla 8eb6088
Remove incorrect comment
githubzilla d5e12be
Set IOSQE_FIXED_FILE for registered dir FD in DeleteBranchFiles
githubzilla 17be9d5
Check cloud delete errors in CloudStoreMgr::DeleteBranchFiles
githubzilla bce3617
Route CreateBranch/DeleteBranch through pending write queue
githubzilla fcc7849
Compact data files before CreateBranch in append mode
githubzilla File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -47,3 +47,4 @@ test-data | |
| target | ||
| tmp | ||
| compile_commands.json | ||
| .pre-commit-config.yaml | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.