Skip to content

update submodule#247

Open
lokax wants to merge 1 commit intoeloqdata:eloq-10.6.10from
lokax:yf-debug-mimalloc
Open

update submodule#247
lokax wants to merge 1 commit intoeloqdata:eloq-10.6.10from
lokax:yf-debug-mimalloc

Conversation

@lokax
Copy link
Collaborator

@lokax lokax commented Mar 10, 2026

Summary by CodeRabbit

  • Chores
    • Updated internal dependency version (no user-facing changes)

Copilot AI review requested due to automatic review settings March 10, 2026 03:35
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the data_substrate git submodule pointer to a newer commit.

Changes:

  • Bumps the data_substrate submodule from 65caaadd... to 06e62967...

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@coderabbitai
Copy link

coderabbitai bot commented Mar 10, 2026

Walkthrough

This pull request updates the data_substrate submodule pointer to track a new commit hash. The change only affects the submodule reference without modifying any functional code within the repository.

Changes

Cohort / File(s) Summary
Submodule Pointer Update
data_substrate
Updated submodule reference from commit 65caaadd93da33fcfb6ee1a1cca73e89cb7529f7 to 06e62967b1dc9da16c00657ceed2b1962a0b2a72.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • Update submodule #187: Updates the same data_substrate submodule pointer to a different commit with no functional code changes.
  • update submodule #186: Performs a pointer-only update to the data_substrate submodule with no code modifications.
  • update subm #189: Updates the data_substrate submodule pointer to a different target commit without code or API changes.

Suggested reviewers

  • liunyl
  • lzxddz

Poem

🐰 A hop, a skip, a pointer's nudge,
The substrate moves along, no fudge,
To newer shores, we gently steer,
With one small commit—the path is clear! 🌟

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'update submodule' is generic and vague, lacking specificity about which submodule is being updated or why. Consider a more specific title such as 'Update data_substrate submodule to 06e62967' to clearly identify which submodule is being updated and provide context.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@data_substrate`:
- Line 1: The data_substrate submodule is pointing to a non-existent commit
(06e62967b1dc9da16c00657ceed2b1962a0b2a72); verify and correct the submodule
pointer by checking the intended commit in the data_substrate repo, update the
submodule reference to a valid commit or branch (e.g., fetch the correct commit,
or set the submodule to the intended branch/head), then commit and push the
updated submodule SHA in the parent repo so the .gitmodules/submodule pointer
for data_substrate references an existing commit; ensure you run git submodule
sync and git submodule update --init after fixing to validate the change.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 65719e65-6082-469d-ab9e-f2b7bfd95297

📥 Commits

Reviewing files that changed from the base of the PR and between 82c9599 and 8d5dcb6.

📒 Files selected for processing (1)
  • data_substrate

@@ -1 +1 @@
Subproject commit 65caaadd93da33fcfb6ee1a1cca73e89cb7529f7
Subproject commit 06e62967b1dc9da16c00657ceed2b1962a0b2a72
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Description: Verify the new submodule commit and check for changes

# Check if the new commit exists in the submodule
cd data_substrate
git fetch origin

# Verify the new commit exists
if ! git cat-file -e 06e62967b1dc9da16c00657ceed2b1962a0b2a72 2>/dev/null; then
  echo "ERROR: Commit 06e62967b1dc9da16c00657ceed2b1962a0b2a72 not found"
  exit 1
fi

echo "=== Commit exists ==="

# Show the commit log between old and new
echo ""
echo "=== Changes between commits ==="
git log --oneline 65caaadd93da33fcfb6ee1a1cca73e89cb7529f7..06e62967b1dc9da16c00657ceed2b1962a0b2a72

# Show detailed changes to public headers
echo ""
echo "=== Changes to public headers ==="
git diff 65caaadd93da33fcfb6ee1a1cca73e89cb7529f7..06e62967b1dc9da16c00657ceed2b1962a0b2a72 -- '*.h' '*.hpp'

# Check for changes to data_substrate.h specifically (used by ha_eloq.cc)
echo ""
echo "=== Changes to data_substrate.h ==="
git diff 65caaadd93da33fcfb6ee1a1cca73e89cb7529f7..06e62967b1dc9da16c00657ceed2b1962a0b2a72 -- '**/data_substrate.h' || echo "No changes or file not found"

# Show the commit message of the new commit
echo ""
echo "=== New commit details ==="
git show --no-patch --format=fuller 06e62967b1dc9da16c00657ceed2b1962a0b2a72

Repository: eloqdata/eloqsql

Length of output: 124


The submodule commit hash does not exist—verify the target commit is correct.

The update references commit 06e62967b1dc9da16c00657ceed2b1962a0b2a72 in data_substrate, but this commit cannot be found in the repository. Verify that the hash is correct, or confirm that the target commit exists on the branch being referenced. This is a blocker—the build will fail if the submodule points to a non-existent commit.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@data_substrate` at line 1, The data_substrate submodule is pointing to a
non-existent commit (06e62967b1dc9da16c00657ceed2b1962a0b2a72); verify and
correct the submodule pointer by checking the intended commit in the
data_substrate repo, update the submodule reference to a valid commit or branch
(e.g., fetch the correct commit, or set the submodule to the intended
branch/head), then commit and push the updated submodule SHA in the parent repo
so the .gitmodules/submodule pointer for data_substrate references an existing
commit; ensure you run git submodule sync and git submodule update --init after
fixing to validate the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants