Skip to content

fix: eloqstore release resources related to shard in own threads inst…#242

Closed
thweetkomputer wants to merge 3 commits intoeloqdata:eloq-10.6.10from
thweetkomputer:fix-resource-release-zc
Closed

fix: eloqstore release resources related to shard in own threads inst…#242
thweetkomputer wants to merge 3 commits intoeloqdata:eloq-10.6.10from
thweetkomputer:fix-resource-release-zc

Conversation

@thweetkomputer
Copy link
Collaborator

@thweetkomputer thweetkomputer commented Mar 2, 2026

…ead of destructor

Summary by CodeRabbit

  • Chores
    • Updated internal dependencies with no impact on user-facing functionality.

@coderabbitai
Copy link

coderabbitai bot commented Mar 2, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 82c9599 and abc24f9.

📒 Files selected for processing (1)
  • data_substrate

Walkthrough

This pull request updates the data_substrate submodule pointer to reference a new commit SHA. The update contains no functional code changes, logic modifications, or API alterations—only the submodule reference is advanced.

Changes

Cohort / File(s) Summary
Submodule Reference
data_substrate
Submodule pointer updated from commit 65caaadd93da33fcfb6ee1a1cca73e89cb7529f7 to 5e0e1345f85ab231a40f23c7109b467c2ef50e34.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • MrGuin

Poem

🐰 A hop, a skip, a reference so fine,
The submodule pointer now points down the line,
No logic was harmed in this commit so neat,
Just pointers updated—a tidy retreat! 🎯

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The PR title partially describes the changeset - it mentions releasing shard resources in own threads instead of destructors, but the actual change is only a submodule pointer update with no functional changes. Update the title to accurately reflect that this is a submodule pointer update (e.g., 'chore: update data_substrate submodule pointer'). The current title implies functional code changes that are not present in this PR.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant