Skip to content

Add engine type prefix to kv_table_name #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lzxddz merged 3 commits into from
Jan 14, 2026
Merged

Add engine type prefix to kv_table_name #206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cbb595d
Add engine type prefix to kv_table_name
lzxddz Jan 9, 2026
8ca4b60
update submodule
lzxddz Jan 13, 2026
8793168
update
lzxddz Jan 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion data_substrate
Open in desktop
Submodule data_substrate updated 19 files
+16 −2 core/src/log_init.cpp
+100 −30 store_handler/data_store_service_client.cpp
+11 −5 store_handler/data_store_service_client.h
+18 −5 store_handler/data_store_service_client_closure.cpp
+30 −2 store_handler/data_store_service_client_closure.h
+10 −0 store_handler/eloq_data_store_service/data_store_factory.h
+8 −1 store_handler/eloq_data_store_service/data_store_service.cpp
+2 −1 store_handler/eloq_data_store_service/data_store_service.h
+15 −17 store_handler/eloq_data_store_service/eloq_store_config.cpp
+1 −2 store_handler/eloq_data_store_service/eloq_store_data_store.cpp
+33 −1 store_handler/eloq_data_store_service/eloq_store_data_store_factory.h
+1 −1 store_handler/eloq_data_store_service/eloqstore
+3 −3 store_handler/eloq_data_store_service/rocksdb_cloud_data_store.cpp
+167 −7 store_handler/rocksdb_handler.cpp
+5 −0 store_handler/rocksdb_handler.h
+4 −0 tx_service/include/cc/cc_req_misc.h
+1 −1 tx_service/include/sequences/sequences.h
+5 −0 tx_service/include/store/data_store_handler.h
+25 −1 tx_service/include/type.h
23 changes: 14 additions & 9 deletions storage/eloq/eloq_db.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -396,7 +396,8 @@ int eloq_create_database(THD *thd, LEX_CSTRING db,
}

auto [yield_func, resume_func]= thd_get_coro_functors(thd);
bool ok= storage_hd->UpsertDatabase(key, {opt_binary.str, opt_binary.length},
bool ok= storage_hd->UpsertDatabase(txservice::TableEngine::EloqSql, key,
{opt_binary.str, opt_binary.length},
yield_func, resume_func);
if (!ok)
{
Expand Down Expand Up @@ -439,7 +440,8 @@ int eloq_update_database(THD *thd, LEX_CSTRING db,
}

auto [yield_func, resume_func]= thd_get_coro_functors(thd);
bool ok= storage_hd->UpsertDatabase(key, {opt_binary.str, opt_binary.length},
bool ok= storage_hd->UpsertDatabase(txservice::TableEngine::EloqSql, key,
{opt_binary.str, opt_binary.length},
yield_func, resume_func);
if (!ok)
{
Expand All @@ -464,7 +466,8 @@ int eloq_drop_database(THD *thd, LEX_CSTRING db)
}

auto [yield_func, resume_func]= thd_get_coro_functors(thd);
bool ok= storage_hd->DropDatabase(key, yield_func, resume_func);
bool ok= storage_hd->DropDatabase(txservice::TableEngine::EloqSql, key,
yield_func, resume_func);
if (!ok)
{
my_printf_error(HA_ERR_INTERNAL_ERROR, "Eloq drop database '%s' failed",
Expand All @@ -486,8 +489,8 @@ int eloq_exist_database(THD *thd, LEX_CSTRING db, bool &exist)

auto [yield_func, resume_func]= thd_get_coro_functors(thd);
std::string data;
bool ok=
storage_hd->FetchDatabase(key, data, exist, yield_func, resume_func);
bool ok= storage_hd->FetchDatabase(txservice::TableEngine::EloqSql, key,
data, exist, yield_func, resume_func);
if (!ok)
{
my_printf_error(HA_ERR_INTERNAL_ERROR, "Eloq fetch database '%s' failed",
Expand All @@ -513,8 +516,8 @@ int eloq_discover_database(THD *thd, LEX_CSTRING db,
auto [yield_func, resume_func]= thd_get_coro_functors(thd);
bool exists= false;
std::string data;
bool ok=
storage_hd->FetchDatabase(key, data, exists, yield_func, resume_func);
bool ok= storage_hd->FetchDatabase(txservice::TableEngine::EloqSql, key,
data, exists, yield_func, resume_func);
if (!ok)
{
my_printf_error(HA_ERR_INTERNAL_ERROR, "Eloq fetch database '%s' failed",
Expand All @@ -539,7 +542,8 @@ int eloq_discover_database_names(THD *thd,

auto [yield_func, resume_func]= thd_get_coro_functors(thd);
std::vector<std::string> names;
bool ok= storage_hd->FetchAllDatabase(names, yield_func, resume_func);
bool ok= storage_hd->FetchAllDatabase(txservice::TableEngine::EloqSql, names,
yield_func, resume_func);
if (!ok)
{
my_printf_error(HA_ERR_INTERNAL_ERROR, "Eloq fetch all databases failed",
Expand All @@ -564,7 +568,8 @@ int eloq_discover_database_names_wild(THD *thd, Discovered_table_list &tl)

auto [yield_func, resume_func]= thd_get_coro_functors(thd);
std::vector<std::string> names;
bool ok= storage_hd->FetchAllDatabase(names, yield_func, resume_func);
bool ok= storage_hd->FetchAllDatabase(txservice::TableEngine::EloqSql, names,
yield_func, resume_func);
if (!ok)
{
my_printf_error(HA_ERR_INTERNAL_ERROR, "Eloq fetch all databases failed",
Expand Down
4 changes: 2 additions & 2 deletions storage/eloq/eloq_i_s.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,8 @@ static int eloq_i_s_temp_table_info_fill_table(THD *thd, TABLE_LIST *tables,

auto [yield_func, resume_func]= thd_get_coro_functors(thd);
std::vector<std::string> table_names;
bool ok=
storage_hd->DiscoverAllTableNames(table_names, yield_func, resume_func);
bool ok= storage_hd->DiscoverAllTableNames(
txservice::TableEngine::EloqSql, table_names, yield_func, resume_func);
if (ok)
{
for (const std::string &table_name : table_names)
Expand Down
10 changes: 6 additions & 4 deletions storage/eloq/ha_eloq.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -821,7 +821,8 @@ static void drop_table(const std::string &table_name_str)
static void drop_orphan_tmp_tables()
{
std::vector<std::string> table_names;
if (storage_hd->DiscoverAllTableNames(table_names))
if (storage_hd->DiscoverAllTableNames(txservice::TableEngine::EloqSql,
table_names))
{
for (const std::string &table_name_str : table_names)
{
Expand Down Expand Up @@ -1013,7 +1014,8 @@ static int eloq_discover_table_names(handlerton *hton, LEX_CSTRING *db,
// Discover table names.
std::vector<std::string> full_name_vec;
auto [yield_func, resume_func]= thd_get_coro_functors(current_thd);
bool ok= storage_hd->DiscoverAllTableNames(full_name_vec, yield_func,
bool ok= storage_hd->DiscoverAllTableNames(txservice::TableEngine::EloqSql,
full_name_vec, yield_func,
resume_func);
if (!ok)
{
Expand Down Expand Up @@ -6645,8 +6647,8 @@ int ha_eloq::create(const char *name, TABLE *table_arg,
bool db_exists= false;

auto [yield_func, resume_func]= my_tx->CoroFunctors();
if (!storage_hd->FetchDatabase(db, db_opt, db_exists, yield_func,
resume_func))
if (!storage_hd->FetchDatabase(txservice::TableEngine::EloqSql, db, db_opt,
db_exists, yield_func, resume_func))
{
DBUG_RETURN(HA_ERR_ELOQ_CREATE_TABLE_FAILED);
}
Expand Down