Skip to content

Support build with eloqstore #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yi-xmu merged 4 commits into from
Dec 9, 2025
Merged

Support build with eloqstore #176

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
caf7e83
update concurse for eloqstore
yi-xmu Dec 4, 2025
24b4ef5
update bash
yi-xmu Dec 4, 2025
4a49225
update bash
yi-xmu Dec 4, 2025
9aa826c
update
yi-xmu Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions concourse/pipeline/build_debug_tarball.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,13 @@ resources:
private_key: ((git-key))
uri: git@github.com:eloqdata/raft_host_manager.git

- name: eloqstore_src_main
type: git
source:
branch: main
private_key: ((git-key))
uri: git@github.com:eloqdata/eloqstore.git

jobs:
- name: ubuntu2204-main
plan:
Expand All @@ -37,9 +44,28 @@ jobs:
resource: logservice_src_main
- get: raft_host_manager_src
resource: raft_host_manager_src_main
- get: eloqstore_src
resource: eloqstore_src_main
- get: image_ubuntu2204
resource: image_ubuntu2204_main

- task: build-eloqstore-type
file: eloqsql_src/concourse/tasks/build_debug_tarball.yml
image: image_ubuntu2204
params:
ASAN: "ON"
TAGGED: ""
GIT_SSH_KEY: ((git-key))
AWS_ACCESS_KEY_ID: ((aws_access_key_id))
AWS_DEFAULT_REGION: ((aws-region))
AWS_SECRET_ACCESS_KEY: ((aws_secret_access_key))
BUILD_LOG_SRV: "true"
BUILD_TYPE: Debug
DATA_STORE_TYPE: ELOQDSS_ELOQSTORE
OUT_NAME: debug
WITH_LOG_STATE: ROCKSDB
CLOUDFRONT_DIST: ((cloudfront-dist))

Comment on lines +52 to +68
Copy link

@coderabbitai coderabbitai bot Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Find pipeline files (nightly and release)
find . -type f -name "*pipeline*" -o -name "*nightly*" -o -name "*release*" | head -20

Repository: eloqdata/eloqsql

Length of output: 176

🏁 Script executed:

#!/bin/bash
# Search for task names containing "eloqstore" or "eloqdss-eloqstore"
rg "build-eloq.*store.*type" --type yaml

Repository: eloqdata/eloqsql

Length of output: 973

Task naming differs from nightly and release pipelines.

The task build-eloqstore-type is inconsistent with nightly (build_nightly_tarball.yml) and release (build_release_tarball.yml) pipelines, which both use build-eloqdss-eloqstore-type. Consider renaming to align with the established naming convention across build pipelines.

🤖 Prompt for AI Agents 
In concourse/pipeline/build_debug_tarball.yml around lines 52 to 68, the task
name "build-eloqstore-type" is inconsistent with nightly/release pipelines;
rename the task to "build-eloqdss-eloqstore-type" to match the established
convention, update any task references in this pipeline or other
pipelines/parent jobs that call this task to the new name, and run a quick
pipeline config lint or dry-run to ensure no remaining references break.

- task: build-rocksdb-cloud-s3-type
file: eloqsql_src/concourse/tasks/build_debug_tarball.yml
image: image_ubuntu2204
Expand All @@ -53,6 +79,7 @@ jobs:
BUILD_TYPE: Debug
DATA_STORE_TYPE: ELOQDSS_ROCKSDB_CLOUD_S3
OUT_NAME: debug
WITH_LOG_STATE: ROCKSDB_CLOUD_S3
CLOUDFRONT_DIST: ((cloudfront-dist))
privileged: true

Expand All @@ -69,6 +96,7 @@ jobs:
BUILD_TYPE: Debug
DATA_STORE_TYPE: ELOQDSS_ROCKSDB
OUT_NAME: debug
WITH_LOG_STATE: ROCKSDB
CLOUDFRONT_DIST: ((cloudfront-dist))
privileged: true

Expand Down
35 changes: 31 additions & 4 deletions concourse/pipeline/build_nightly_tarball.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,13 @@ resources:
private_key: ((git-key))
uri: git@github.com:eloqdata/raft_host_manager.git

- name: eloqstore_src_main
type: git
source:
branch: main
private_key: ((git-key))
uri: git@github.com:eloqdata/eloqstore.git

jobs:
- name: ubuntu2004-main
plan:
Expand All @@ -55,6 +62,8 @@ jobs:
resource: logservice_src_main
- get: raft_host_manager_src
resource: raft_host_manager_src_main
- get: eloqstore_src
resource: eloqstore_src_main
- get: image_ubuntu2004
resource: image_ubuntu2004_main

Expand All @@ -70,6 +79,7 @@ jobs:
BUILD_TYPE: RelWithDebInfo
DATA_STORE_TYPE: ELOQDSS_ROCKSDB_CLOUD_S3
OUT_NAME: nightly
WITH_LOG_STATE: ROCKSDB_CLOUD_S3
CLOUDFRONT_DIST: ((cloudfront-dist))

- task: build-eloqdss-rocksdb-type
Expand All @@ -84,9 +94,10 @@ jobs:
BUILD_TYPE: RelWithDebInfo
DATA_STORE_TYPE: ELOQDSS_ROCKSDB
OUT_NAME: nightly
WITH_LOG_STATE: ROCKSDB
CLOUDFRONT_DIST: ((cloudfront-dist))

- task: build-eloqstore-type
- task: build-eloqdss-eloqstore-type
file: eloqsql_src/concourse/tasks/build_nightly_tarball.yml
image: image_ubuntu2004
params:
Expand All @@ -98,6 +109,7 @@ jobs:
BUILD_TYPE: RelWithDebInfo
DATA_STORE_TYPE: ELOQDSS_ELOQSTORE
OUT_NAME: nightly
WITH_LOG_STATE: ROCKSDB_CLOUD_S3
CLOUDFRONT_DIST: ((cloudfront-dist))

serial: true
Expand All @@ -113,6 +125,8 @@ jobs:
resource: logservice_src_main
- get: raft_host_manager_src
resource: raft_host_manager_src_main
- get: eloqstore_src
resource: eloqstore_src_main
- get: image_ubuntu2204
resource: image_ubuntu2204_main

Expand All @@ -128,6 +142,7 @@ jobs:
BUILD_TYPE: RelWithDebInfo
DATA_STORE_TYPE: ELOQDSS_ROCKSDB_CLOUD_S3
OUT_NAME: nightly
WITH_LOG_STATE: ROCKSDB_CLOUD_S3
CLOUDFRONT_DIST: ((cloudfront-dist))

- task: build-eloqdss-rocksdb-type
Expand All @@ -142,9 +157,10 @@ jobs:
BUILD_TYPE: RelWithDebInfo
DATA_STORE_TYPE: ELOQDSS_ROCKSDB
OUT_NAME: nightly
WITH_LOG_STATE: ROCKSDB
CLOUDFRONT_DIST: ((cloudfront-dist))

- task: build-eloqstore-type
- task: build-eloqdss-eloqstore-type
file: eloqsql_src/concourse/tasks/build_nightly_tarball.yml
image: image_ubuntu2204
params:
Expand All @@ -156,6 +172,7 @@ jobs:
BUILD_TYPE: RelWithDebInfo
DATA_STORE_TYPE: ELOQDSS_ELOQSTORE
OUT_NAME: nightly
WITH_LOG_STATE: ROCKSDB_CLOUD_S3
CLOUDFRONT_DIST: ((cloudfront-dist))

serial: true
Expand All @@ -171,6 +188,8 @@ jobs:
resource: logservice_src_main
- get: raft_host_manager_src
resource: raft_host_manager_src_main
- get: eloqstore_src
resource: eloqstore_src_main
- get: image_ubuntu2404
resource: image_ubuntu2404_main

Expand All @@ -186,6 +205,7 @@ jobs:
BUILD_TYPE: RelWithDebInfo
DATA_STORE_TYPE: ELOQDSS_ROCKSDB_CLOUD_S3
OUT_NAME: nightly
WITH_LOG_STATE: ROCKSDB_CLOUD_S3
CLOUDFRONT_DIST: ((cloudfront-dist))

- task: build-eloqdss-rocksdb-type
Expand All @@ -200,9 +220,10 @@ jobs:
BUILD_TYPE: RelWithDebInfo
DATA_STORE_TYPE: ELOQDSS_ROCKSDB
OUT_NAME: nightly
WITH_LOG_STATE: ROCKSDB
CLOUDFRONT_DIST: ((cloudfront-dist))

- task: build-eloqstore-type
- task: build-eloqdss-eloqstore-type
file: eloqsql_src/concourse/tasks/build_nightly_tarball.yml
image: image_ubuntu2404
params:
Expand All @@ -214,6 +235,7 @@ jobs:
BUILD_TYPE: RelWithDebInfo
DATA_STORE_TYPE: ELOQDSS_ELOQSTORE
OUT_NAME: nightly
WITH_LOG_STATE: ROCKSDB_CLOUD_S3
CLOUDFRONT_DIST: ((cloudfront-dist))

serial: true
Expand All @@ -229,6 +251,8 @@ jobs:
resource: logservice_src_main
- get: raft_host_manager_src
resource: raft_host_manager_src_main
- get: eloqstore_src
resource: eloqstore_src_main
- get: image_centos7
resource: image_centos7_main

Expand All @@ -244,6 +268,7 @@ jobs:
BUILD_TYPE: RelWithDebInfo
DATA_STORE_TYPE: ELOQDSS_ROCKSDB_CLOUD_S3
OUT_NAME: nightly
WITH_LOG_STATE: ROCKSDB_CLOUD_S3
CLOUDFRONT_DIST: ((cloudfront-dist))

- task: build-eloqdss-rocksdb-type
Expand All @@ -258,9 +283,10 @@ jobs:
BUILD_TYPE: RelWithDebInfo
DATA_STORE_TYPE: ELOQDSS_ROCKSDB
OUT_NAME: nightly
WITH_LOG_STATE: ROCKSDB
CLOUDFRONT_DIST: ((cloudfront-dist))

- task: build-eloqstore-type
- task: build-eloqdss-eloqstore-type
file: eloqsql_src/concourse/tasks/build_nightly_tarball.yml
image: image_centos7
params:
Expand All @@ -272,6 +298,7 @@ jobs:
BUILD_TYPE: RelWithDebInfo
DATA_STORE_TYPE: ELOQDSS_ELOQSTORE
OUT_NAME: nightly
WITH_LOG_STATE: ROCKSDB_CLOUD_S3
CLOUDFRONT_DIST: ((cloudfront-dist))

serial: true
Loading