Skip to content

update submodule: fix TableName missed destruction and construct union member to avoid UB#162

Closed
thweetkomputer wants to merge 1 commit intoeloqdata:eloq-10.6.10from
thweetkomputer:table_variant_zc
Closed

update submodule: fix TableName missed destruction and construct union member to avoid UB#162
thweetkomputer wants to merge 1 commit intoeloqdata:eloq-10.6.10from
thweetkomputer:table_variant_zc

Conversation

@thweetkomputer
Copy link
Collaborator

@thweetkomputer thweetkomputer commented Nov 13, 2025

Summary by CodeRabbit

  • Chores
    • Updated dependency reference.

This release contains no user-facing changes and is primarily a maintenance update.

@coderabbitai
Copy link

coderabbitai bot commented Nov 13, 2025

Warning

Rate limit exceeded

@thweetkomputer has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 3 minutes and 2 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 1b39c6a and 327efbb.

📒 Files selected for processing (1)
  • storage/eloq/tx_service (1 hunks)

Walkthrough

The pull request updates the storage/eloq/tx_service submodule commit reference, advancing it from b5f974df8a9d66dcb29436376105d59adc6512da to 8b619a71c17db8d07949adc042f8a406dac16342. No functional changes were introduced.

Changes

Cohort / File(s) Change Summary
Submodule Update
storage/eloq/tx_service
Updated commit reference pointer to reflect upstream changes in the tx_service submodule

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • lzxddz

Poem

🐰 A tiny hop through the submodule tree,
One commit whispers to another with glee,
From b5f974 to 8b619 we dance,
Storage grins at its fresh advance! ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Title check ⚠️ Warning The PR title describes fixing TableName destruction and union member construction, but the raw summary shows only a submodule commit reference change with no functional changes detected. Update the title to accurately reflect that this is a submodule reference update, or clarify the actual nature of the changes if the summary is incomplete.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@thweetkomputer thweetkomputer changed the title update submodule: use variant for TableName update submodule: fix TableName missed destruction and construct union member to avoid UB Nov 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant