Large object lru

[xiexiaoy]

Configuration options:

• cache_evict_policy: LRU | LO_LRU. LRU by default.
• lolru_large_obj_threshold_kb: 1024 by default.

eloqdata/tx_service#426

Summary by CodeRabbit

• Chores
  • Updated an internal submodule pointer; no functional or API changes and no user-facing impact.
  • Adjusted internal test/startup script defaults to include additional backend startup options; changes are internal-only and do not alter public behavior.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 52fd2f50-8598-4de7-8dd0-b6b519f2c287

📥 Commits

Reviewing files that changed from the base of the PR and between 684b3bb and 22fa3a3.

📒 Files selected for processing (2)

• concourse/scripts/common.sh
• data_substrate

🚧 Files skipped from review as they are similar to previous changes (2)

• concourse/scripts/common.sh
• data_substrate

---

Walkthrough

Submodule data_substrate pointer advanced to commit c8fdcc4f2b367737145826cf64b797bd0b8bba7a, and concourse/scripts/common.sh had two eloqkv startup options added (cache_evict_policy=LO_LRU, lolru_large_obj_threshold_kb=1); no public API changes.

Changes

Cohort / File(s)	Summary
Submodule Update data_substrate	Submodule pointer updated from f94af0016... to c8fdcc4f2... (metadata-only commit bump; no functional/API changes).
Concourse script change concourse/scripts/common.sh	In run_eloqkv_cluster_tests (ELOQDSS_ELOQSTORE branch) added two eloqkv startup CLI options: cache_evict_policy=LO_LRU and lolru_large_obj_threshold_kb=1 (added alongside existing flags; indentation adjusted).

Sequence Diagram(s)

(Skipped — changes are a submodule pointer update and small CLI additions; no new multi-component control flow introduced.)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related issues

• [Feature]: Enhance cache eviction policy to support payload-size-aware eviction tx_service#417 — Introduces LO_LRU eviction and large-object-threshold behavior matching the new eloqkv startup options added here.

Possibly related PRs

• update submodule #361 — Submodule pointer update for data_substrate (same type of change).
• chore:update eloqstore submodule and adapt to eloqstore parameter change #372 — Related eloqstore/eloqkv configuration changes; overlaps with startup/config edits.
• Run eloq-test for standby eloqstore #452 — Modifies eloqkv startup/configuration in concourse/scripts/common.sh (touches same script/area).

Suggested reviewers

• thweetkomputer

Poem

🐰 A hop, a nudge, a tiny tweak,
Two flags for cache, one pointer sleek.
Submodule fresh, the scripts align,
Tests will run — the tree grows fine. 🥕

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'Large object lru' is directly related to the main changes, which add cache eviction policy options including LO_LRU and a large object threshold configuration.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}