Skip to content

warm up standby local ssd #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
liunyl merged 1 commit into from
Nov 20, 2025
Merged

warm up standby local ssd #288

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -580,6 +580,7 @@ elseif((WITH_DATA_STORE STREQUAL "ELOQDSS_ROCKSDB_CLOUD_S3") OR
store_handler/eloq_data_store_service/rocksdb_config.cpp
store_handler/eloq_data_store_service/purger_event_listener.cpp
store_handler/eloq_data_store_service/purger_sliding_window.cpp
store_handler/eloq_data_store_service/s3_file_downloader.cpp
)
elseif(WITH_DATA_STORE STREQUAL "ELOQDSS_ROCKSDB")
SET(RESELOQ_RESOURCES ${RESELOQ_RESOURCES}
Expand Down
14 changes: 14 additions & 0 deletions src/redis_service.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,6 +365,9 @@ DEFINE_string(eloq_dss_peer_node,
DEFINE_string(eloq_dss_branch_name,
"development",
"Branch name of EloqDataStore");
DEFINE_uint32(dss_file_cache_sync_interval_sec,
30,
"File cache sync interval in seconds for standby warm-up");
#endif

namespace EloqKV
Expand Down Expand Up @@ -1037,6 +1040,14 @@ bool RedisServiceImpl::Init(brpc::Server &brpc_server)
: config_reader.GetString(
"store", "eloq_dss_peer_node", FLAGS_eloq_dss_peer_node);

uint32_t dss_file_cache_sync_interval_sec =
!CheckCommandLineFlagIsDefault("dss_file_cache_sync_interval_sec")
? FLAGS_dss_file_cache_sync_interval_sec
: config_reader.GetInteger(
"store",
"dss_file_cache_sync_interval_sec",
FLAGS_dss_file_cache_sync_interval_sec);
Copy link

@cursor cursor bot Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Negative config value silently converted to large positive

The config_reader.GetInteger() method returns a long (signed type), which is assigned to dss_file_cache_sync_interval_sec of type uint32_t (unsigned). If a user provides a negative value in the configuration file, it will be implicitly converted to a large positive uint32_t value through two's complement representation, potentially causing the file cache sync to occur at an unexpectedly long interval instead of being rejected as invalid.

Fix in Cursor Fix in Web


std::string eloq_dss_data_path = eloq_data_path + "/eloq_dss";
if (!std::filesystem::exists(eloq_dss_data_path))
{
Expand Down Expand Up @@ -1086,6 +1097,9 @@ bool RedisServiceImpl::Init(brpc::Server &brpc_server)
ds_config);
}

// Set file cache sync interval
ds_config.SetFileCacheSyncIntervalSec(dss_file_cache_sync_interval_sec);

#if defined(DATA_STORE_TYPE_ELOQDSS_ROCKSDB_CLOUD_S3) || \
defined(DATA_STORE_TYPE_ELOQDSS_ROCKSDB_CLOUD_GCS)
EloqDS::RocksDBConfig rocksdb_config(config_reader, eloq_dss_data_path);
Expand Down
2 changes: 1 addition & 1 deletion store_handler
Open in desktop
Submodule store_handler updated 15 files
+5 −0 eloq_data_store_service/CMakeLists.txt
+48 −0 eloq_data_store_service/data_store_factory.h
+478 −0 eloq_data_store_service/data_store_service.cpp
+71 −0 eloq_data_store_service/data_store_service.h
+14 −0 eloq_data_store_service/data_store_service_config.cpp
+16 −1 eloq_data_store_service/data_store_service_config.h
+15 −0 eloq_data_store_service/ds_request.proto
+45 −0 eloq_data_store_service/eloq_store_data_store_factory.h
+36 −0 eloq_data_store_service/internal_request.h
+109 −3 eloq_data_store_service/rocksdb_cloud_data_store.cpp
+14 −0 eloq_data_store_service/rocksdb_cloud_data_store.h
+40 −0 eloq_data_store_service/rocksdb_cloud_data_store_factory.h
+40 −0 eloq_data_store_service/rocksdb_data_store_factory.h
+163 −0 eloq_data_store_service/s3_file_downloader.cpp
+68 −0 eloq_data_store_service/s3_file_downloader.h