Skip to content

Sharding keys on one range partition into on core#471

Merged
yi-xmu merged 3 commits intomainfrom
shard_keys_one_core_of_rangepartition
Mar 16, 2026
Merged

Sharding keys on one range partition into on core#471
yi-xmu merged 3 commits intomainfrom
shard_keys_one_core_of_rangepartition

Conversation

@yi-xmu
Copy link
Collaborator

@yi-xmu yi-xmu commented Mar 13, 2026

Update submodule.

Summary by CodeRabbit

  • Chores

    • Updated an internal dependency reference and applied non-functional whitespace/formatting adjustments.
  • Note

    • No user-visible changes, behavior updates, or new features in this release; functionality remains unchanged.

@yi-xmu yi-xmu self-assigned this Mar 13, 2026
@yi-xmu yi-xmu requested a review from liunyl March 13, 2026 10:57
@coderabbitai
Copy link

coderabbitai bot commented Mar 13, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 9f50108a-752b-46ba-b1b7-d240c2f907e2

📥 Commits

Reviewing files that changed from the base of the PR and between d67fe66 and 5e44b8e.

📒 Files selected for processing (1)
  • src/mongo/db/modules/eloq/data_substrate
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/mongo/db/modules/eloq/data_substrate

Walkthrough

This PR advances the src/mongo/db/modules/eloq/data_substrate submodule commit and adjusts whitespace/indentation for the batchReadCatalog declaration in src/mongo/db/modules/eloq/src/eloq_recovery_unit.h. No API or behavioral changes were introduced.

Changes

Cohort / File(s) Summary
Submodule Update
src/mongo/db/modules/eloq/data_substrate
Updated submodule commit hash pointer; no source changes in this repo.
Header whitespace
src/mongo/db/modules/eloq/src/eloq_recovery_unit.h
Whitespace/indentation adjusted for batchReadCatalog declaration only; signature unchanged.

Sequence Diagram(s)

(omitted)

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • thweetkomputer
  • liunyl
  • lzxddz

Poem

🐰 I hopped to bump a tiny hash,
Tabs aligned in one soft dash,
No logic changed, just tidy lines,
A quiet fix where sunlight shines,
Cheers — a rabbit's gentle splash.

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title 'Sharding keys on one range partition into on core' appears to reference database partitioning concepts, but the actual PR only updates a submodule commit hash and adjusts whitespace with no functional changes. Revise the title to accurately reflect the PR's actual content, such as 'Update eloq data substrate submodule' or 'Whitespace adjustment in eloq recovery unit header'.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (1 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch shard_keys_one_core_of_rangepartition
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@src/mongo/db/modules/eloq/data_substrate`:
- Line 1: The PR references a non-existent submodule commit
(5eb0b7ac217628a4f1af3ca1ebd94d518bcfc5ff) for the submodule at
src/mongo/db/modules/eloq/data_substrate; to fix, verify the correct commit hash
in the submodule repo and either push the missing commit to the remote or update
the submodule reference to a valid pushed commit, then update the submodule
pointer in this repo (e.g., sync and update the submodule reference and commit)
and re-run the commit so the submodule gitlink points to a reachable remote ref.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: cffb6755-c7f2-4adc-9b09-f1d6560ea0a4

📥 Commits

Reviewing files that changed from the base of the PR and between 3addf9c and 6590ed7.

📒 Files selected for processing (1)
  • src/mongo/db/modules/eloq/data_substrate

@yi-xmu yi-xmu merged commit 9db45c3 into main Mar 16, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants