Skip to content

fix: eloqstore release resources related to shard in own threads inst…#468

Open
thweetkomputer wants to merge 3 commits intoeloqdata:mainfrom
thweetkomputer:fix-resource-release-zc
Open

fix: eloqstore release resources related to shard in own threads inst…#468
thweetkomputer wants to merge 3 commits intoeloqdata:mainfrom
thweetkomputer:fix-resource-release-zc

Conversation

@thweetkomputer
Copy link
Collaborator

@thweetkomputer thweetkomputer commented Mar 2, 2026

…ead of destructor

Summary by CodeRabbit

  • Chores
    • Updated an internal repository pointer to a newer commit. There are no functional, configuration, or public API changes, no behavioral differences, and no user-visible impact. This is a low-risk maintenance update.

@coderabbitai
Copy link

coderabbitai bot commented Mar 2, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 910e897 and ea1f8fe.

📒 Files selected for processing (1)
  • src/mongo/db/modules/eloq/data_substrate
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/mongo/db/modules/eloq/data_substrate

Walkthrough

This PR updates the embedded submodule commit pointer for src/mongo/db/modules/eloq/data_substrate from 140d611df46c00272055cc3c0116dd17c047b047 to 5e0e1345f85ab231a40f23c7109b467c2ef50e34. No functional code, configuration, or API modifications were made.

Changes

Cohort / File(s) Summary
Submodule Pointer Update
src/mongo/db/modules/eloq/data_substrate
Bumped embedded commit hash from 140d611df46c00272055cc3c0116dd17c047b047 to 5e0e1345f85ab231a40f23c7109b467c2ef50e34. No code or public API changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • liunyl
  • yi-xmu

Poem

🐰 A twitch of whiskers, a quiet hop,
The pointer nudged forward, no code to stop.
Just a hash refreshed on a branch so neat,
I left tiny tracks with my nimble feet. 🥕

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title describes a specific implementation detail (releasing resources in threads instead of destructor) that matches the submodule update, making it directly related to the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant