Skip to content

Fix create index memory unbounded#396

Open
liunyl wants to merge 1 commit intomainfrom
index_mem
Open

Fix create index memory unbounded#396
liunyl wants to merge 1 commit intomainfrom
index_mem

Conversation

@liunyl
Copy link
Contributor

@liunyl liunyl commented Dec 25, 2025

Summary by CodeRabbit

  • Chores
    • Updated internal dependencies to latest versions with no user-facing changes or API modifications.

✏️ Tip: You can customize this high-level summary in your review settings.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Ubuntu seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@coderabbitai
Copy link

coderabbitai bot commented Dec 25, 2025

Walkthrough

Updates the submodule pointer for src/mongo/db/modules/eloq/data_substrate to a new commit reference. No code or public API changes are introduced in the main repository as a result of this submodule update.

Changes

Cohort / File(s) Summary
Submodule Pointer Update
src/mongo/db/modules/eloq/data_substrate
Updated submodule commit reference from 8dce439e5e0c668da292e11486f42fd470cd19d4 to dd1e7fd02d3d9170f01a6f74d3d9f63567ade3ac; no functional changes in consuming code

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • update submodule #341: Updates the same src/mongo/db/modules/eloq/data_substrate submodule pointer to a new commit.
  • update subm #386: Also updates the src/mongo/db/modules/eloq/data_substrate submodule by advancing its commit pointer.
  • update submoulde #375: Modifies the same submodule pointer by updating its tracked commit hash.

Suggested reviewers

  • lzxddz
  • yi-xmu

Poem

🐰 A pointer hops to a new hash today,
No code changes come along the way,
Just a reference shift, clean and small,
The submodule glides through it all! 📍

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Title check ⚠️ Warning The PR title 'Fix create index memory unbounded' describes fixing a memory issue with index creation, but the actual change is only a submodule pointer update with no code changes detected. Update the title to reflect that this is a submodule update (e.g., 'Update data_substrate submodule') or clarify if the memory fix is contained within the submodule update.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch index_mem

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3220e86 and ffde980.

📒 Files selected for processing (1)
  • src/mongo/db/modules/eloq/data_substrate
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: githubzilla
Repo: eloqdata/eloqdoc PR: 211
File: src/mongo/db/modules/eloq/cmake/build_eloq_log_service.cmake:26-80
Timestamp: 2025-09-25T12:24:06.434Z
Learning: The user githubzilla implemented a fix in commit fe98aaf to address the MEMORY state incorrectly triggering RocksDB discovery in build_eloq_log_service.cmake. This was a control flow issue where MEMORY builds were falling into an else branch that still attempted RocksDB discovery.
Learnt from: githubzilla
Repo: eloqdata/eloqdoc PR: 279
File: src/mongo/db/modules/eloq/CMakeLists.txt:54-55
Timestamp: 2025-11-28T10:55:21.020Z
Learning: In src/mongo/db/modules/eloq/CMakeLists.txt, the CMake options EXT_TX_PROC_ENABLED, FORK_HM_PROCESS, and STATISTICS are used by the data_substrate submodule build system and should be retained as configuration interface options.
📚 Learning: 2025-11-28T10:55:21.020Z
Learnt from: githubzilla
Repo: eloqdata/eloqdoc PR: 279
File: src/mongo/db/modules/eloq/CMakeLists.txt:54-55
Timestamp: 2025-11-28T10:55:21.020Z
Learning: In src/mongo/db/modules/eloq/CMakeLists.txt, the CMake options EXT_TX_PROC_ENABLED, FORK_HM_PROCESS, and STATISTICS are used by the data_substrate submodule build system and should be retained as configuration interface options.

Applied to files:

  • src/mongo/db/modules/eloq/data_substrate
🔇 Additional comments (1)
src/mongo/db/modules/eloq/data_substrate (1)

1-1: Submodule addition is properly configured.

The data_substrate submodule has been added (not updated) with commit dd1e7fd02d3d9170f01a6f74d3d9f63567ade3ac pointing to https://github.com/eloqdata/tx_service.git. The commit hash format is valid and the message aligns with the PR objective ("Fix create index memory unbounded"). The CMakeLists.txt retains the required options (EXT_TX_PROC_ENABLED, FORK_HM_PROCESS, STATISTICS).


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants