Skip to content

check module registration before unregistering #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MrGuin merged 2 commits into from
Nov 10, 2025
Merged

check module registration before unregistering #14

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
237367d
check module registration before unregistering
MrGuin Nov 10, 2025
237c359
format
MrGuin Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion src/bthread/eloq_module.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,9 @@
#include "bthread/bthread.h"

extern "C" {
bthread::TaskControl* bthread_get_task_control();
bthread::TaskControl *bthread_get_task_control();
}

extern std::array<eloq::EloqModule *, 10> registered_modules;
extern std::atomic<int> registered_module_cnt;

Expand All @@ -47,6 +48,17 @@ namespace eloq {
}

int unregister_module(EloqModule *module) {
// Verify that the module is currently registered.
std::shared_lock s_lk(module_mutex);
const bool exists = std::find(registered_modules.begin(),
registered_modules.end(),
module) != registered_modules.end();
if (!exists) {
LOG(WARNING) << "Attempted to unregister a non-registered module: " << module;
return -1;
}
s_lk.unlock();

const auto concurrency = bthread_get_task_control()->concurrency();
while (module->registered_workers_.load(std::memory_order_acquire) != concurrency) {
for (int thd_id = 0; thd_id < concurrency; ++thd_id) {
Expand Down
Loading