Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After some prodding, GPT-5 claims the following about this branch:
UI and UX changes
codetations.darkModesetting in the extension.setDarkModemessage type for toggling from the webview.Annotation and retagging changes
parsePatchand document content caching.Internal and API changes
setDarkModeandopen-externalwebview message types.Merge checklist
npm run devin all three terminals).setDarkMode,open-external) are handled without errors.codetations.darkModesetting does not conflict with any settings added since May 2025.Merge-Prep Checklist —
polishbranch (features only)Robust diff handling & logging
vscode-extension/src/AnnotationTracker.tsparsePatchimport and avalidatePatch(...)flow before applying diffs.LOG_LEVELSconstant andthis.log(...)calls replacing rawconsole.*.Failed to apply document diff for annotation ${ann.id}. Using fallback.Invalid document diff for annotation ${ann.id}. Using fallback.Error applying document diff for annotation ${ann.id}:Created patch for annotation ${ann.id} could not be validated. Using full document content instead.Error creating document diff for annotation ${ann.id}:original document diff)globalDocument = document.getText()when persisting annotations.documentContentCache,pendingChangesmaps.validatePatch,LOG_LEVELS,this.log(,documentDiff,originalDocumentDiff, the strings above.Retagging UX: clearer error when nothing comes back
vscode-extension/src/panels/AnnotationManagerPanel.tsvscode-extension/src/panels/BaseAnnotationView.tsError retagging annotation: no result returnedError retagging annotation: no result returned (maybe all annotation anchor text was deleted?)const updatedAnnotations: Annotation[] = []in manager panel.maybe all annotation anchor text was deleted?,updatedAnnotations: Annotation[].Dark mode plumbing (persisted flag + UI toggle)
vscode-extension/src/panels/BaseAnnotationView.tsvscode-extension/webview-ui/src/App.cssvscode-extension/webview-ui/src/App.tsxvscode-extension/webview-ui/src/DarkModeToggle.tsxcodetations.darkMode(stored viavscode.workspace.getConfiguration().update(...))."setDarkMode"(no active editor required) and"open-external"now usesvscode.Uri.parse.isDarkModein the"initialize"payload.:rootandbody.dark-mode, plus a fixed-position.dark-mode-togglebutton.codetations.darkMode,"setDarkMode","open-external",isDarkMode,body.dark-mode,.dark-mode-toggle.New webview components for polish
vscode-extension/webview-ui/src/AnnotationTile.tsx.annotation-tile,.annotation-info,.line-number,.annotation-type,.needs-retag-indicator,.delete-button.annotation.metadata?.color.AnnotationTile.tsx,needs-retag-indicator,annotation.metadata?.color.vscode-extension/webview-ui/src/AddAnnotationBanner.tsx.add-note-banner,.add-note-content,.add-note-header,.add-note-form,.annotation-type-select,.add-note-actionsand primary/secondary buttons.toolNamesandtoolTypes.AddAnnotationBanner.tsx,annotation-type-select,toolNames.vscode-extension/webview-ui/src/Header.tsx,vscode-extension/webview-ui/src/EmptyState.tsxHeader.tsx,EmptyState.tsx.App.cssexpanded with theme tokens and styles for the new components..annotation-tile,.add-note-*, new CSS variable block.Misc
.gitignore: added**/.claude/settings.local.json..claude/settings.local.json.