Improve documentation for String.Extra.classify #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gampleman
reviewed
Jun 28, 2025
| classify "myLittleCamel.class.name" --> "MyLittleCamelClassName" | ||
| classify "München" --> "MNchen" |
Collaborator
There was a problem hiding this comment.
Hm... is there ever a point where this is desirable behavior? And is there a way to fix it or is this one of those parts of Elm where there isn't really a great workaround?
Collaborator
Author
There was a problem hiding this comment.
It's not desirable, no, but we can't fix it without some form of unicode support, and the only current path (elm-unicode) would add an unacceptable size to the bundle.
I prefer to document it rather than leave it as a surprise though.
The "clean" fix would be to have a new version of elm/regex with support for enabling the unicode flag.
Collaborator
There was a problem hiding this comment.
Ok thanks for the explanation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think "non-word" was not a great wording. I've also added an example to make it clear how it deals (or doesn't deal) with Unicode.
"non-word" kinda makes sense if you look at it from a regex point of view but:
[\W_]not[\W]