Inline call to Result.map in Result.Extra.andMap for performance
#71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Looking at the screenshots, it doesn't look like it even particularly improves performance in most cases, no? Also I'd suggest that in real world uses there is a fair likelihood that |
Collaborator
Author
|
Eh, fair enough. I hoped for a bigger change but I guess the JIT is doing a good job |
Collaborator
|
I'm happy to merge the benchmarks to record this experiment for the future, but I don't think they support changing the implementation. |
miniBill
force-pushed
the
result-extra-andmap-inlining
branch
from
f1c2191 to
d378f90
Compare
miniBill
force-pushed
the
result-extra-andmap-inlining
branch
from
d378f90 to
25b0c1c
Compare
Collaborator
Author
|
Left only the benchmarks in and merged |
Collaborator
Author
|
Ah, the squashed commit's message is. Wrong :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This inlines the call to
Result.mapinResult.Extra.andMap, because we're already pattern matching on the values, might as well do it completely and save a function call.The performance improvements are minor, but the code size increase is also minor, so it's a tradeoff. I picked this function in particular because it's the one we use the most at work.
Benchmarks
Firefox
Chrome