Draft
Conversation
|
You can set this PR to a draft, so it can't be merged |
elliotchance
force-pushed
the
main
branch
5 times, most recently
from
170d1fc to
aac5b37
Compare
elliotchance
force-pushed
the
i90-orm
branch
2 times, most recently
from
8d76f33 to
a220a6d
Compare
DO NOT MERGE. This is partial support for the ORM. However, there are some challenges that need to be addressed before this can be properly reviewed and landed: 1. The ORM in V requires drivers to be hard-coded. See #90. 2. The Connection doesn't _really_ implement orm.Connection because the vsql Connection is required to be mut and the current interface definition does not allow this. 3. We need to create a new test suite for the ORM. `vsql/orm_test.v` filled with combinations of statements "sql" commands will work just fine. Specifically, we need to test different combinations of expressions and types. Fixes #90
elliotchance
force-pushed
the
i90-orm
branch
from
a220a6d to
dc6a494
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE.
This is partial support for the ORM. However, there are some challenges
that need to be addressed before this can be properly reviewed and
landed:
The ORM in V requires drivers to be hard-coded. See Support for builtin orm #90.
The Connection doesn't really implement orm.Connection because the
vsql Connection is required to be mut and the current interface
definition does not allow this.
We need to create a new test suite for the ORM.
vsql/orm_test.vfilled with combinations of statements "sql" commands will work just
fine. Specifically, we need to test different combinations of
expressions and types.
Fixes #90