Skip to content

Conversation

@ellenhp
Copy link
Owner

@ellenhp ellenhp commented Sep 29, 2025

Fixes #172

@ellenhp ellenhp requested a review from Copilot September 29, 2025 22:16
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements search keyboard action functionality, allowing users to trigger search by pressing the search/enter key on the keyboard. The primary enhancement focuses on improving the search user experience and adding better map pin visualization for search results.

Key changes:

  • Added keyboard search action support with proper IME handling
  • Enhanced map pin functionality to display search results as interactive pins
  • Refactored transit models to avoid naming conflicts with the main Place class

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
cardinal-android/app/src/main/java/earth/maps/cardinal/ui/home/HomeScreen.kt Added keyboard actions, search event handling, and geocode results visualization
cardinal-android/app/src/main/java/earth/maps/cardinal/ui/home/HomeViewModel.kt Converted geocodeResults to StateFlow and added geocodePlaces mapping
cardinal-android/app/src/main/java/earth/maps/cardinal/ui/core/MapView.kt Updated map pins to use Place objects instead of Position
cardinal-android/app/src/main/java/earth/maps/cardinal/ui/core/AppContent.kt Enhanced search result handling with camera animation and bounding box calculation
cardinal-android/app/src/main/java/earth/maps/cardinal/ui/core/MapViewModel.kt Added createFeatureFromPlace method and updated layer IDs for map pin queries
cardinal-android/app/src/main/java/earth/maps/cardinal/data/Place.kt Added toPosition() helper method
cardinal-android/app/src/main/java/earth/maps/cardinal/data/BoundingBox.kt Added toGeoJsonBoundingBox() conversion method
cardinal-android/app/src/main/java/earth/maps/cardinal/transit/TransitousModels.kt Renamed Place to TransitPlace to avoid naming conflicts
cardinal-android/app/src/main/java/earth/maps/cardinal/transit/TransitousService.kt Updated to use TransitPlace instead of Place
cardinal-android/app/src/main/java/earth/maps/cardinal/ui/directions/TransitItineraryDetailScreen.kt Updated property references to use TransitPlace
cardinal-android/app/src/main/java/earth/maps/cardinal/ui/home/OfflineAreasScreen.kt Removed trailing whitespace

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@ellenhp ellenhp merged commit 5978b52 into main Sep 29, 2025
1 check passed
@ellenhp ellenhp deleted the ellenhp/search_action branch September 29, 2025 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Do not add new line on search field when user press enter

2 participants