Skip to content

Do not force journal mode unless specified #341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
warmwaffles merged 1 commit into from
Dec 22, 2025
Merged

Do not force journal mode unless specified #341

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/exqlite/connection.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -464,7 +464,7 @@ defmodule Exqlite.Connection do
end

defp set_journal_mode(db, options) do
maybe_set_pragma(db, "journal_mode", Pragma.journal_mode(options))
set_pragma_if_present(db, "journal_mode", Keyword.get(options, :journal_mode))
end

defp set_temp_store(db, options) do
Expand Down
12 changes: 12 additions & 0 deletions test/exqlite/connection_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,18 @@ defmodule Exqlite.ConnectionTest do
assert {:error, "attempt to write a readonly database"} ==
Sqlite3.execute(ro_state.db, insert_value_query)
end

test "preserves WAL mode across connections" do
path = Temp.path!()

{:ok, state1} = Connection.connect(database: path, journal_mode: :wal)
assert {:ok, "wal"} = get_pragma(state1.db, :journal_mode)

{:ok, state2} = Connection.connect(database: path)
assert {:ok, "wal"} = get_pragma(state2.db, :journal_mode)

File.rm(path)
end
end

defp get_pragma(db, pragma_name) do
Expand Down