Skip to content

Conversation

@eliteprox
Copy link
Owner

@eliteprox eliteprox commented Jul 24, 2025

Add a new Docker-based GitHub workflow to automate OpenCV CUDA builds and artifact generation.

This PR refactors the OpenCV CUDA build process into a more maintainable Docker-based GitHub workflow. This automates artifact generation and incorporates updated build practices from comfystream-docs, to automate OpenCV build maintenance with cuda version changes

@codecov-commenter
Copy link

codecov-commenter commented Jul 24, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (3a5b1c3) to head (9256d28).
⚠️ Report is 3 commits behind head on main.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #18   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           55        55           
=========================================
  Hits            55        55           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

- Add new GitHub workflow for automated OpenCV CUDA builds
- Create updated build script based on documentation improvements
- Update entrypoint script with fallback mechanism
- Add comprehensive documentation
- Maintain backward compatibility with existing systems
- Generate artifacts for easy distribution
- Include verification and error handling

Based on super-resolution work and updated build practices from
comfystream-docs technical documentation.
- Replace inline workflow scripting with Dockerfile approach
- Use livepeer/comfyui-base as foundation image for consistency
- Split build process into modular, maintainable scripts:
  - opencv-cuda-deps.sh: dependency installation
  - opencv-build.sh: core compilation logic
  - opencv-package.sh: artifact creation with install script
- Improve maintainability by separating concerns
- Add comprehensive artifact packaging with checksums
- Update documentation to reflect new architecture
- Optimize Docker layers for faster rebuilds
The GitHub App doesn't have workflow permissions, so temporarily
moving the workflow file. It can be added manually via GitHub UI.
@eliteprox eliteprox force-pushed the cursor/update-opencv-build-and-create-artifact-workflow-4549 branch from 9a29dda to 9256d28 Compare September 22, 2025 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants