updates Keras and tensorflow version [MNT]#47
Closed
solegalli wants to merge 3 commits intoeli5-org:masterfrom
Closed
updates Keras and tensorflow version [MNT]#47solegalli wants to merge 3 commits intoeli5-org:masterfrom
solegalli wants to merge 3 commits intoeli5-org:masterfrom
Conversation
Contributor
|
@solegalli I think with current state of Keras 3, it seems better to target using |
This was referenced Mar 22, 2025
Contributor
|
See also #31 which seems to add support for more recent TF versions |
Contributor
|
Thanks for starting this @solegalli , let me close this one as now we support modern Keras via #58 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the moment, there are 4 tests that are failing in
test_keras.py. But more important than that, Keras has migrated itsbackendfunctionality.Currently, we do
import keras.backend as Kand from K we use functions likeargmax,gradientand so on. Those functions don't live there any more. I think, we may find them intensforflow.keras.backend, but I am not absolutely sure. Anyhow, if we swapkeras.backendfortensorflow.keras.backend, then we get other errors, like keras can't accept a tensorflow tensor.I am not an avid Keras/tensorflow user, so I am a bit lost here. Any help/pointers will be welcome!
Anyhow, i think we need to update the files explain_prediction.py and grandcam.py inside the keras folder inside eli5.
FYI @lopuhin @kmike