Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds GitHub Actions workflows to enable Claude Code integration, allowing AI-assisted development through @claude mentions in issues and pull requests, as well as automatic code reviews on PRs.
Key Changes
- Added
.github/workflows/claude.ymlfor interactive Claude assistance triggered by @claude mentions - Added
.github/workflows/claude-code-review.ymlfor automatic code reviews on opened/synchronized PRs
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
.github/workflows/claude.yml |
Main workflow that triggers Claude Code when @claude is mentioned in comments, reviews, or issues |
.github/workflows/claude-code-review.yml |
Automated code review workflow that runs on PR open/sync events with customizable review criteria |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| pull-requests: read | ||
| issues: read | ||
| id-token: write | ||
| actions: read # Required for Claude to read CI results on PRs |
There was a problem hiding this comment.
The comment on line 26 states that 'actions: read' is required for Claude to read CI results on PRs, but this permission is already declared on line 26. The comment is redundant with the code. Consider removing the comment since the purpose is already clear from the additional_permissions section below (lines 39-41) which documents this feature more comprehensively.
| actions: read # Required for Claude to read CI results on PRs | |
| actions: read |
| # This is an optional setting that allows Claude to read CI results on PRs | ||
| additional_permissions: | | ||
| actions: read | ||
There was a problem hiding this comment.
The 'additional_permissions' configuration on lines 40-41 sets 'actions: read', but this permission is already declared in the permissions section on line 26. This duplication is redundant and may cause confusion. Remove the 'additional_permissions' section or the 'actions: read' from the permissions section to avoid duplication.
| # This is an optional setting that allows Claude to read CI results on PRs | |
| additional_permissions: | | |
| actions: read |
| contents: read | ||
| pull-requests: read | ||
| issues: read |
There was a problem hiding this comment.
The workflow has read-only permissions but the PR description states "Claude's default tools are limited to reading/writing files and interacting with our repo by creating comments, branches, and commits." To create comments, branches, and commits, Claude needs write permissions. Add 'pull-requests: write', 'issues: write', and 'contents: write' to the permissions section.
| contents: read | |
| pull-requests: read | |
| issues: read | |
| contents: write | |
| pull-requests: write | |
| issues: write |
| pull-requests: read | ||
| issues: read |
There was a problem hiding this comment.
The workflow has read-only permissions for pull-requests and issues, but the prompt instructs Claude to use 'gh pr comment' to leave feedback. This requires write permissions. Add 'pull-requests: write' and 'issues: write' to the permissions section to allow Claude to post review comments.
| pull-requests: read | |
| issues: read | |
| pull-requests: write | |
| issues: write |
| - name: Checkout repository | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| fetch-depth: 1 |
There was a problem hiding this comment.
The fetch-depth is set to 1, which performs a shallow clone. For Claude Code to properly analyze changes and context, especially when reviewing PRs, it may need access to more commit history. Consider increasing fetch-depth to 0 (full history) or a larger number to ensure Claude has adequate context for analysis.
| fetch-depth: 1 | |
| fetch-depth: 0 |
| - name: Checkout repository | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| fetch-depth: 1 |
There was a problem hiding this comment.
The fetch-depth is set to 1, which performs a shallow clone. For code review purposes, Claude may need access to more commit history to understand the context of changes and compare against base branches. Consider increasing fetch-depth to 0 (full history) or a larger number to ensure adequate context for thorough reviews.
| fetch-depth: 1 | |
| fetch-depth: 0 |
| pull_request_review_comment: | ||
| types: [created] | ||
| issues: | ||
| types: [opened, assigned] |
There was a problem hiding this comment.
The workflow is triggered on 'issues' with types 'opened' and 'assigned'. However, the condition on line 19 only checks if the issue body or title contains '@claude'. This means the workflow will run for every issue assignment even if @claude is not mentioned, wasting CI resources. Consider removing 'assigned' from the trigger types or adjusting the condition to handle assignments differently.
| types: [opened, assigned] | |
| types: [opened] |
1 participant
🤖 Installing Claude Code GitHub App
This PR adds a GitHub Actions workflow that enables Claude Code integration in our repository.
What is Claude Code?
Claude Code is an AI coding agent that can help with:
How it works
Once this PR is merged, we'll be able to interact with Claude by mentioning @claude in a pull request or issue comment.
Once the workflow is triggered, Claude will analyze the comment and surrounding context, and execute on the request in a GitHub action.
Important Notes
Security
There's more information in the Claude Code action repo.
After merging this PR, let's try mentioning @claude in a comment on any PR to get started!