Skip to content

Conversation

@GeekyEggo
Copy link
Member

No description provided.

@GeekyEggo GeekyEggo requested a review from ChekTek June 26, 2025 14:05
@GeekyEggo GeekyEggo requested a review from Copilot June 26, 2025 14:10
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors how command arguments are handled to resolve DEP0190 by moving the arguments into the command string and simplifying the function signatures.

  • Removed the separate args parameter from run and forget functions in runner.ts.
  • Updated usage of run() in runUrl, create, and tryOpenVSCode commands to pass a single command string.
  • Updated Node.js version in GitHub workflows to 20.19.0.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
src/common/runner.ts Removed the args parameter and consolidated arguments into command strings; updated runUrl accordingly.
src/commands/create.ts Updated dependency installation and build commands by using string interpolation for the command.
.github/workflows/release.yml Updated Node.js version from 20.15.0 to 20.19.0.
.github/workflows/build.yml Updated Node.js version from 20.15.0 to 20.19.0.
Comments suppressed due to low confidence (2)

src/commands/create.ts:45

  • [nitpick] The renamed variable npm may be ambiguous if the package manager is not necessarily npm; consider using a more descriptive name like packageManagerCmd.
	const { packageManager: npm } = getConfig();

src/common/runner.ts:46

  • When constructing command strings by concatenation (e.g., using start ${url} and open ${url} -g), ensure that the url parameter is properly sanitized to prevent potential shell injection vulnerabilities.
	if (platform() === "win32") {

@GeekyEggo GeekyEggo merged commit fbee5fc into main Jul 4, 2025
2 checks passed
@GeekyEggo GeekyEggo deleted the DEP0190 branch July 4, 2025 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants