Skip to content

[APP-2533] Add renewal banner for Ally#537

Merged
rami-elementor merged 2 commits intodevelopfrom
APP-2533
Mar 18, 2026
Merged

[APP-2533] Add renewal banner for Ally#537
rami-elementor merged 2 commits intodevelopfrom
APP-2533

Conversation

@rami-elementor
Copy link
Copy Markdown
Member

@rami-elementor rami-elementor commented Mar 18, 2026

Related: #531

Replace custom MS_IN_ONE_DAY with WordPress DAY_IN_SECONDS constant.

✨ PR Description

Purpose: Fix timestamp unit inconsistency in renewal notice dismissal logic by converting from milliseconds to seconds-based tracking.

Main changes:

  • Removed MS_IN_ONE_DAY constant and replaced millisecond calculations with WordPress DAY_IN_SECONDS constant
  • Updated dismiss_per_user() to store Unix timestamp in seconds instead of milliseconds
  • Modified is_dismissed_for_today() comparison logic to use seconds-based time calculation for consistency

Generated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using.
💡 Tip: You can customize your AI Description using Guidelines Learn how

@rami-elementor rami-elementor changed the title App 2533 [APP-2533] Add renewal banner for Ally Mar 18, 2026
@rami-elementor rami-elementor merged commit 08a4dcc into develop Mar 18, 2026
73 checks passed
@rami-elementor rami-elementor deleted the APP-2533 branch March 18, 2026 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants