Skip to content

[APP-2532] Improve admin notice accessibility #535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rami-elementor merged 1 commit into from
Mar 18, 2026
Merged

[APP-2532] Improve admin notice accessibility #535

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/legacy/components/admin.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ public function admin_notices() {
}
}
</style>
<div class="notice updated is-dismissible a11y-notice a11y-install-elementor">
<div role="region" aria-label="<?php esc_attr_e( 'Notice', 'pojo-accessibility' ); ?>" class="notice updated is-dismissible a11y-notice a11y-install-elementor">
<div class="a11y-notice-inner">
<div class="a11y-notice-icon">
<svg width="50" height="50" viewBox="0 0 28 28" fill="none" xmlns="http://www.w3.org/2000/svg">
Expand Down
5 changes: 3 additions & 2 deletions modules/settings/notices/renewal-notice.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ public function content(): string {
$this->type = $text['type'];
$icon = $this->get_notice_icon( $text['type'] );
return sprintf(
'<div class="ea11y__notice-icon">%s</div><div class="ea11y__notice-content"><b>%s</b><span>%s</span><a class="ea11y__renewal-notice-btn" href="%s" target="_blank" rel="noopener noreferrer">%s</a></div>',
'<div class="ea11y__notice-icon" aria-hidden="true">%s</div><div class="ea11y__notice-content"><b>%s</b><span>%s</span><a class="ea11y__renewal-notice-btn" href="%s" target="_blank" rel="noopener noreferrer">%s</a></div>',
$icon,
$text['title'],
$text['description'],
Expand All @@ -138,7 +138,8 @@ public function render() {
$text = ( null !== $this->days_diff ) ? $this->get_renewal_text() : [ 'type' => $this->type ];
$type_attr = isset( $text['type'] ) ? $text['type'] : $this->type;
printf(
'<div class="notice notice-info ea11y-dismiss is-dismissible ea11y__notice ea11y__notice--%1$s ea11y__renewal-notice" data-notice-id="%2$s" data-notice-action="%3$s" data-notice-nonce="%4$s"><div class="ea11y__content-block">%5$s</div></div>',
'<div role="region" aria-label="%1$s" class="notice notice-info ea11y-dismiss is-dismissible ea11y__notice ea11y__notice--%2$s ea11y__renewal-notice" data-notice-id="%3$s" data-notice-action="%4$s" data-notice-nonce="%5$s"><div class="ea11y__content-block">%6$s</div></div>',
esc_attr__( 'Notice', 'pojo-accessibility' ),
esc_attr( $type_attr ),
esc_attr( $this->get_id() ),
esc_attr( $this->get_action_name() ),
Expand Down
Loading