Skip to content

[APP-2532] Improve admin notice accessibility #534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rami-elementor merged 5 commits into from
Mar 17, 2026
Merged

[APP-2532] Improve admin notice accessibility #534

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3ea3fc9
Improve admin notice accessibility accessibility
rami-elementor Mar 17, 2026
b17f81c
Merge branch 'develop' into accessible-admin-notices
rami-elementor Mar 17, 2026
d851947
Improve admin notice accessibility
rami-elementor Mar 17, 2026
3c65f92
Improve admin notice accessibility
rami-elementor Mar 17, 2026
8babec5
Improve admin notice accessibility
rami-elementor Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion classes/utils/notice-base.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,8 @@ public function handle_dismiss() {
}

public function render() {
echo sprintf( '<div class="notice_wrapper notice %1$s notice-%2$s %2$s %3$s" data-notice-id="%3$s" data-notice-action="%4$s" data-notice-nonce="%5$s">%6$s</div>',
echo sprintf( '<div role="region" aria-label="%1$s" class="notice_wrapper notice %2$s notice-%3$s %3$s %4$s" data-notice-id="%4$s" data-notice-action="%5$s" data-notice-nonce="%6$s">%7$s</div>',
esc_attr__( 'Notice', 'pojo-accessibility' ),
$this->is_dismissible ? 'ea11y-dismiss is-dismissible' : '',
esc_attr( $this->type ),
esc_attr( $this->get_id() ),
Expand Down
Loading