MainWindow: use settings.create_action#160
Merged
Conversation
ryonakano
reviewed
Jul 17, 2025
Member
ryonakano
left a comment
There was a problem hiding this comment.
Leaving two tiny comments (and one self-talk)
Co-authored-by: Ryo Nakano <ryonakaknock3@gmail.com>
ryonakano
approved these changes
Jul 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I still kept the transform instead of making the enum reflect map source IDs because we're going to want to keep those separate for dark mode. That way the setting is always
exploreortransitand then in the transform func we can figure out if that meansexplore-darkorexplore-lightetc.If dark mode is set, we can change the map source from
explore-lighttoexplore-darkand that won't trigger a write to gsettings since the user setting didn't change here, just the name of the map source we're currently using