Skip to content

MainWindow: add icons for map source buttons#154

Merged
ryonakano merged 3 commits intomainfrom
danirabbit/map-source-buttons
Jul 16, 2025
Merged

MainWindow: add icons for map source buttons#154
ryonakano merged 3 commits intomainfrom
danirabbit/map-source-buttons

Conversation

@danirabbit
Copy link
Member

@danirabbit danirabbit commented Jul 15, 2025

Do something a bit more visually interesting with the map options submenu:

  • Create icons for map sources
  • I changed the names of the maps because I don't think "Mapnik" means anything to most people and I think "Transit" is probably better American English. I'm not terribly attached to "Explore" I just couldn't think of a better name and this is what Apple Maps calls it. Google Maps just calls it "Default"
  • Add color scheme options as a section instead of a submenu
Screenshot from 2025-07-15 13 31 58

@danirabbit danirabbit requested a review from a team July 15, 2025 20:35
@ryonakano
Copy link
Member

Explore always looks as if selected (just focused actually) even if you select Transit and reopen the popover 🤔

スクリーンショット 2025-07-16 7 13 37

@danirabbit
Copy link
Member Author

Explore always looks as if selected (just focused actually) even if you select Transit and reopen the popover

@ryonakano Yeah this is more of a stylesheet bug because it's using :focus instead of :focus-visible for its keyboard focus styles. I'd prefer to address it there

@danirabbit
Copy link
Member Author

Proposed elementary/stylesheet#1330

@ryonakano
Copy link
Member

Proposed elementary/stylesheet#1330

Thank you for your quick fix, I confirmed the issue resolved with latest main branch of stylesheet:

スクリーンショット 2025-07-16 20 30 45
diff --git a/io.elementary.maps.yml b/io.elementary.maps.yml
index 914e5af..5ea5bf4 100644
--- a/io.elementary.maps.yml
+++ b/io.elementary.maps.yml
@@ -12,6 +12,37 @@ finish-args:
 build-options:
   libdir: /app/lib
 modules:
+  - name: sassc
+    buildsystem: autotools
+    sources:
+      - type: archive
+        url: https://github.com/sass/sassc/archive/3.6.2.tar.gz
+        sha256: 608dc9002b45a91d11ed59e352469ecc05e4f58fc1259fc9a9f5b8f0f8348a03
+      - type: script
+        dest-filename: autogen.sh
+        commands:
+          - autoreconf -si
+    modules:
+      - name: libsass
+        buildsystem: autotools
+        sources:
+          - type: archive
+            url: https://github.com/sass/libsass/archive/3.6.5.tar.gz
+            sha256: 89d8f2c46ae2b1b826b58ce7dde966a176bac41975b82e84ad46b01a55080582
+          - type: script
+            dest-filename: autogen.sh
+            commands:
+              - autoreconf -si
+
+  - name: stylesheet
+    buildsystem: meson
+    cleanup:
+      - /share/metainfo
+    sources:
+      - type: git
+        url: https://github.com/elementary/stylesheet.git
+        commit: 3d7e2b74ad8bddb19128bc2afaeaa7e343f8046a
+
   - name: geocode-glib-2.0
     buildsystem: meson
     config-opts:

Copy link
Member

@ryonakano ryonakano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really love this design, thank you very much!

@ryonakano ryonakano merged commit 001c09f into main Jul 16, 2025
3 checks passed
@ryonakano ryonakano deleted the danirabbit/map-source-buttons branch July 16, 2025 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants