Skip to content

Conversation

@devin-ai-integration
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot commented Jan 25, 2026

Summary

Fixes the ClickHouse CI test failure caused by permission denied errors when GitHub Actions' setup-python action scans the workspace for pip caching.

The ClickHouse container was using a bind mount (./clickhouse-data:/var/lib/clickhouse) which creates files with root ownership. When the CI runner (non-root user) tries to scan directories for pip caching, it fails with EACCES: permission denied, scandir '.../clickhouse-data/access'.

This change switches to a named Docker volume (consistent with how postgres and pgadmin are already configured), which keeps the data in Docker's volume storage and avoids the permission issue.

Review & Testing Checklist for Human

  • Verify the ClickHouse CI tests pass after merging (this is the primary validation)
  • Confirm no local development workflows depend on accessing ./clickhouse-data directly

Notes

Link to Devin run: https://app.devin.ai/sessions/cc081bf8267d4c2c831e339f0814bda5
Requested by: Yosef Arbiv (@arbiv)

Summary by CodeRabbit

  • Chores
    • Updated data persistence configuration in testing infrastructure to use named volumes for improved reliability and consistency.

✏️ Tip: You can customize this high-level summary in your review settings.

The ClickHouse container was using a bind mount (./clickhouse-data) which creates
files with root ownership. When GitHub Actions' setup-python action scans the
workspace for pip caching, it fails with 'permission denied' on the clickhouse-data
directory.

This change switches to a named Docker volume (consistent with postgres and pgadmin),
which keeps the data in Docker's volume storage and avoids the permission issue.

Co-Authored-By: Yosef Arbiv <yosef.arbiv@gmail.com>
@devin-ai-integration
Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@github-actions
Copy link
Contributor

👋 @devin-ai-integration[bot]
Thank you for raising your pull request.
Please make sure to add tests and document all user-facing changes.
You can do this by editing the docs files in the elementary repository.

@coderabbitai
Copy link

coderabbitai bot commented Jan 25, 2026

📝 Walkthrough

Walkthrough

The Docker Compose configuration is updated to use a named volume for ClickHouse data storage instead of a host path mount, improving portability and consistency across environments.

Changes

Cohort / File(s) Summary
Docker Compose Configuration
integration_tests/docker-compose.yml
Replaces ClickHouse host path mount (./clickhouse-data:/var/lib/clickhouse) with named volume (clickhouse:/var/lib/clickhouse); adds clickhouse volume declaration to top-level volumes section.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A volume so named, no paths in the way,
ClickHouse data now dances the Docker ballet!
Portable and clean, through networks it flows,
Where data persists and the container grows! 🎉

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately and specifically describes the main change: switching ClickHouse from a bind mount to a named volume to resolve CI permission issues.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@arbiv arbiv merged commit 2396f71 into master Jan 27, 2026
50 of 60 checks passed
@arbiv arbiv deleted the devin/1769336177-fix-clickhouse-volume-permissions branch January 27, 2026 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant