Fix: Prevent crashes when updateService undefined #1214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The updateService can be undefined when service workers are not available or not configured. This causes crashes when trying to call updateAuthData. Add optional chaining (?.) to both updateService.updateAuthData calls in Client.js to prevent crashes in environments where service workers are not supported or configured. Fixes crashes when updateService is undefined due to missing service worker configuration or unsupported browser environment. Signed-off-by: Vladimir Pal <this@vlad-pal.net>
VladimirPal
force-pushed
the
fix/updateservice-optional-chaining
branch
from
4f8e40c to
5c7fb12
Compare
VladimirPal
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The updateService can be undefined when service workers are not available or not configured. This causes crashes when trying to call updateAuthData.
Add optional chaining (?.) to both updateService.updateAuthData calls in Client.js to prevent crashes in environments where service workers are not supported or configured.
Fixes crashes when updateService is undefined due to missing service worker configuration or unsupported browser environment.
Note: This bug has likely gone unnoticed because errors in the sync process are silently swallowed by empty catch blocks in Sync.js, making failures invisible.