Render unknown events and message types so users don't miss messages #1197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helps users not to miss anything unnoticed. Clearly state that a message is not supported by hydrogen so users can check their messages with a different client. Signed-off-by: Mirian Margiani <mixosaurus+ichthyo@pm.me>
Signed-off-by: Mirian Margiani <mixosaurus+ichthyo@pm.me>
Signed-off-by: Mirian Margiani <mixosaurus+ichthyo@pm.me>
Signed-off-by: Mirian Margiani <mixosaurus+ichthyo@pm.me>
Unknown messages are rendered using the fallback plain text representation, including a notice that the message is not supported. Signed-off-by: Mirian Margiani <mixosaurus+ichthyo@pm.me>
Signed-off-by: Mirian Margiani <mixosaurus+ichthyo@pm.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new tile shape "unknown-event" that is shown when an unknown event or message type is received. If it is a message, then the shape will render as a message (with username and avatar), otherwise it is rendered as an announcement.
Some events are handled outside of the tile handling logic, so they are explicitly not added to the timeline. Some other events don't have their own tile implementations at the moment, but they are less important and can safely be hidden without users missing much info. This reduces spam in the timeline.
Ideally, all events should get their own tiles, or it should be a conscious decision not to render a specific event.
Unsupported events:
Unsupported messages:
(I actually implemented
m.stickerandm.audioin #1195.)Fixes #1196.
Related to #1187.
Related to #1195.