Enhance docstrings and assertions on Ingresses tests#1113
Open
gaelgatelement wants to merge 1 commit intomainfrom
Open
Enhance docstrings and assertions on Ingresses tests#1113gaelgatelement wants to merge 1 commit intomainfrom
gaelgatelement wants to merge 1 commit intomainfrom
Conversation
gaelgatelement
force-pushed
the
gaelg/enhance-assert-messages-ingresses
branch
from
20b9f78 to
926b294
Compare
benbz
reviewed
Mar 11, 2026
|
|
||
| When Helm values configure specific hostnames for ingress resources: | ||
| - Ingress rules must use the exact hostnames specified in values | ||
| - For well-known deployables, use serverName if no host is specified |
Member
There was a problem hiding this comment.
Suggested change
| - For well-known deployables, use serverName if no host is specified | |
| - For the well-known deployable, use serverName |
| Ingress resources must not have ingressClassName by default. | ||
|
|
||
| When no specific ingress class is configured, Ingress resources should not include | ||
| an ingressClassName field. This allows the default ingress controller to handle |
Member
There was a problem hiding this comment.
Suggested change
| an ingressClassName field. This allows the default ingress controller to handle | |
| an ingressClassName field. This allows the cluster's default IngressClass to handle |
| - Backend services must use the specified service type (LoadBalancer) | ||
| - Services must apply the configured traffic policies (internalTrafficPolicy, externalTrafficPolicy) | ||
| - Services must include global annotations | ||
| - Services must target named ports |
Member
There was a problem hiding this comment.
Suggested change
| - Services must target named ports |
While this is asserted, it isn't something we configure
Member
Author
There was a problem hiding this comment.
I'm not sure to follow your reasoning here?
Member
There was a problem hiding this comment.
All of the other items in this list are settings in the values file. This item isn't
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.