-
Notifications
You must be signed in to change notification settings - Fork 109
Update README.md Clarification on port 443, revisions to external proxy instructions #1110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AndyQuantonium
wants to merge
4
commits into
element-hq:main
Choose a base branch
from
AndyQuantonium:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
29864f5
Update README.md
AndyQuantonium ffdef17
revised phrasing about TCP port 443 for Matrix RTC
AndyQuantonium 84ef7fa
revised readme as manually applying traefik-config.yaml shouldn't be …
AndyQuantonium 6bd3d3f
Merge branch 'main' into main
AndyQuantonium File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is that really not required ? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's the config in my server:
Like with issue #1060 I was getting the issue where the port wouldn't change despite the file being present. I tried different things, what I know is this config I have works. Though one thing in peculiar, the external IP traefik's service is on is the external IP to the server (ideally I would want this set manually to an internal IP).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried without setting an external IP and it would not bind here AFAICT. That's a bit surprising.
I agree that it would be great to make k3s traefik to bind on alternatively on a local IP. If you are able to document it that would be a very valuable contribution!