-
Notifications
You must be signed in to change notification settings - Fork 870
Expose service to let Element X access some internal data #9109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
|
||
| import android.os.Bundle | ||
|
|
||
| interface DataImporter { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a thought: would this be better named DataExporter? Then on the EX side it is named "importer"? e.g. the EX importer talks to the EC exporter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. This file will be removed in a future version of the code, which just have the ImporterService. Maybe I should name it ExporterService, but since it's used by EX to import a session, I am not sure.
Note: Using permission "${applicationId}.READ_DATA" with android:protectionLevel="normal" does not work in release mode.
e364976 to
2fc12ad
Compare
|
Type of change
Content
Temporary code to let Element X access some internal data.
See element-hq/element-x-android#6013 for more details.
Motivation and context
Part of element-hq/element-meta#3073
Screenshots / GIFs
Tests
Tested devices
Checklist