Switch to logging in __init__.py, set load message to debug#171
Merged
electronstudio merged 3 commits intoelectronstudio:masterfrom Jun 4, 2025
incognitojam:use-logging
Merged
Switch to logging in __init__.py, set load message to debug#171electronstudio merged 3 commits intoelectronstudio:masterfrom incognitojam:use-logging
__init__.py, set load message to debug#171electronstudio merged 3 commits intoelectronstudio:masterfrom
incognitojam:use-logging
Conversation
- Replace print statements with logger.error() and logger.debug() calls. - Follow best practices by using a module-specific logger via getLogger(__name__). - Use parameterized log messages to avoid unnecessary string formatting. - Change the "RAYLIB STATIC x.x.x LOADED" message from direct stderr output to logger debug level. Motivation: In [commaai/openpilot#35076][openpilot-issue], we experienced noisy test outputs because the RAYLIB STATIC message is printed unnecessarily, cluttering stderr. This change allows library consumers to control the visibility of this message. [openpilot-issue]: commaai/openpilot#35076
Owner
|
I think we should have similar behaviour to Raylib itself:
I'm not sure the best way to achieve this. The default log level is WARNING so |
Owner
use warning rather than debug logging
Contributor
Author
|
Sorry for the delay here, I'm not working on this project anymore |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
logger.error()andlogger.debug()calls.getLogger(__name__).Motivation:
In commaai/openpilot#35076, we experienced noisy test outputs because the RAYLIB STATIC message is printed unnecessarily, cluttering stderr. This change allows library consumers to control the visibility of this message.