fix: update the PE checksum after committing changes #106
+61
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(And fixes duplicate bug electron#101: Triggers false positive for windows defender golang)
erickzhao
changed the title
|
@dsanders11 any possible way to merge this? |
|
Hello! Since the pull request was stuck with the old build system (and old commit), I've re-created the PR based on the latest commit here: FirehawkV21@495b739 I'd be happy to either bring over the changes to that fork or create a new PR that replaces it, if necessary. EDIT: I realised that I mentioned the wrong PR on my fork's commit. It is this PR that I re-created. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #50, #101
Yes, I was lazy and didn't bother to use GetLastError anywhere, because none of the other code does it...